Unify the version string to be displayed on "About Chromium" dialog. (1/6)

Unify the version string to be displayed on "About Chromium" dialog. (1/6)

We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the first step of them:

(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan)

BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Linux)" on Linux.

[haraken1, 2011-07-21 14:40:46]

erg, tony: Would you please take a look at it?

[haraken1, 2011-07-21 14:41:31]

erg, tony: Would you please take a look at it?

[tony, 2011-07-21 17:32:50]

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
File chrome/common/chrome_version_info.cc (right):

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:99: current_version +=
l10n_util::GetStringUTF8(IDS_ABOUT_VERSION_UNOFFICIAL);
What happened to the version_info.IsOfficialBuild() check?

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:117: return "Mac OS X";
I would put this in the mac change for mark to review.

[Elliot Glaysher, 2011-07-21 17:52:54]

The changes to the gtk file LGTM

[haraken1, 2011-07-22 00:08:18]

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
File chrome/common/chrome_version_info.cc (right):

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:99: current_version +=
l10n_util::GetStringUTF8(IDS_ABOUT_VERSION_UNOFFICIAL);
On 2011/07/21 17:32:50, tony wrote:
> What happened to the version_info.IsOfficialBuild() check?

Here is inside the block of "#if !defined(GOOGLE_CHROME_BUILD)", and so there is
no case of the official build(, as Mark indicated previously.)

http://codereview.chromium.org/7468027/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:117: return "Mac OS X";
On 2011/07/21 17:32:50, tony wrote:
> I would put this in the mac change for mark to review.

Done.

[tony, 2011-07-22 16:48:07]

LGTM!

[commit-bot: I haz the power, 2011-07-23 01:49:52]

Try job failure for 7468027-6001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-07-23 03:33:48]

Change committed as 93774