Issue 7468025: secure proxy support in websocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7468025: secure proxy support in websocket (Closed)

Created:
9 years, 5 months ago by ukai

Modified:
9 years, 5 months ago

Reviewers:
Takashi Toyoshima, Yuta Kitamura

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Ryan Hamilton

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

secure proxy support in websocket BUG=83950 TEST=net_unittest --gtest_filter=SocketStreamTest.* pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93860

Patch Set 2 : add unittest #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -44 lines)			Patch
M	net/socket_stream/socket_stream.h	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	net/socket_stream/socket_stream.cc	View	1	5 chunks	+90 lines, -44 lines	0 comments	Download
M	net/socket_stream/socket_stream_metrics.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket_stream/socket_stream_unittest.cc	View	1	1 chunk	+105 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Looks good. Yuta, Could you review this as net OWNERS? http://codereview.chromium.org/7468025/diff/1/net/socket_stream/socket_stream.cc File net/socket_stream/socket_stream.cc (right): http://codereview.chromium.org/7468025/diff/1/net/socket_stream/socket_stream.cc#newcode668 ...

9 years, 5 months ago (2011-07-21 11:37:44 UTC) #2

Yuta Kitamura

Code looks legit. Do you have any idea about testing this change?

9 years, 5 months ago (2011-07-21 11:54:23 UTC) #3

Sorry for delay, LGTM.

Expand Messages | Collapse Messages

Issue 7468025: secure proxy support in websocket (Closed)

Description

Patch Set 1 #

Patch Set 2 : add unittest #

Messages