Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 7468024: Fix overlap check in MoveBlock and fix assertion. (Closed)

Created:
9 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 5 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix overlap check in MoveBlock and fix assertion. The old code was adding a size in words to a byte*. Should use size in bytes. Also, the assertions were doing signed comparisons on pointers instead of unsigned. Fixing the assertions makes one of the assertions identical to the condition just before it. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/heap-inl.h View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 5 months ago (2011-07-21 10:33:47 UTC) #1
fschneider
9 years, 5 months ago (2011-07-21 10:47:53 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698