Update bisect-builds.py to automatically determine download server.

If good..bad range is all before or after the recent build cutoff, use the appropriate server.

If good..bad straddles the recent build cutoff, test out the oldest recent build. If that build is good, bisect only recent builds from build.chromium.org. If that build is bad, bisect only old builds.

BUG=89974
TEST=(1) run bisect-builds.py with defaults; (2) accept default good/bad args; when chrome starts, close it and specify good; verify that further downloads come from build.chromium.org domain. Repeat (1) and (2); specify bad; verify that further downloads come from commondatastorage.googleapis.com.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93432

[jbates, 2011-07-21 01:03:47]

(rsesek - feel free to review as well if you want)

[Nico, 2011-07-21 16:17:31]

Mostly LG. One real comment and a few nits

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode209
tools/bisect-builds.py:209: |bad_revision| of the |context|."""
Update docstring.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode357
tools/bisect-builds.py:357: context = PathContext(opts.archive, 0, 0, False)
Name parameter (|..., use_recent=False)|) – more readable

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode393
tools/bisect-builds.py:393: all_revs_recent.sort()
I think you want
    all_revs_recent = all_revs_recent[1:]
after this line

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode395
tools/bisect-builds.py:395: oldest_recent_rev = all_revs_recent[1]
and then use [0] here

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode402
tools/bisect-builds.py:402: context.use_recent = True # set True to test recent
build
Remove comment

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode413
tools/bisect-builds.py:413: all_revs = all_revs_recent
This includes 0 -- probably not intentional? (hence my suggestion above)

[jbates, 2011-07-21 17:36:01]

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode209
tools/bisect-builds.py:209: |bad_revision| of the |context|."""
On 2011/07/21 16:17:31, Nico wrote:
> Update docstring.

Done.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode357
tools/bisect-builds.py:357: context = PathContext(opts.archive, 0, 0, False)
On 2011/07/21 16:17:31, Nico wrote:
> Name parameter (|..., use_recent=False)|) – more readable

Done.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode393
tools/bisect-builds.py:393: all_revs_recent.sort()
On 2011/07/21 16:17:31, Nico wrote:
> I think you want
>     all_revs_recent = all_revs_recent[1:]
> after this line

Done.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode395
tools/bisect-builds.py:395: oldest_recent_rev = all_revs_recent[1]
On 2011/07/21 16:17:31, Nico wrote:
> and then use [0] here

Done.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode402
tools/bisect-builds.py:402: context.use_recent = True # set True to test recent
build
On 2011/07/21 16:17:31, Nico wrote:
> Remove comment

Done.

http://codereview.chromium.org/7468020/diff/1/tools/bisect-builds.py#newcode413
tools/bisect-builds.py:413: all_revs = all_revs_recent
On 2011/07/21 16:17:31, Nico wrote:
> This includes 0 -- probably not intentional? (hence my suggestion above)

0 would be filtered out before bisecting, but I like your solution better.

[Nico, 2011-07-21 17:38:27]

LGTM