Issue 7468017: Http Cache: Keep track of whether we are doing byte range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7468017: Http Cache: Keep track of whether we are doing byte range (Closed)

Created:
9 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 5 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Http Cache: Keep track of whether we are doing byte range requests because the caller is asking for a range, and save 200 responses when we ask for a range but we don't have a sparse entry. BUG=81820 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93669

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -22 lines)			Patch
M	net/http/http_cache_transaction.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/http/http_cache_transaction.cc	View	7 chunks	+24 lines, -20 lines	2 comments	Download
M	net/http/http_cache_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gavinp

LGTM. My first mid-air code review. :-) http://codereview.chromium.org/7468017/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): http://codereview.chromium.org/7468017/diff/1/net/http/http_cache_transaction.cc#newcode1281 net/http/http_cache_transaction.cc:1281: // Balanced ...

9 years, 5 months ago (2011-07-21 22:11:22 UTC) #3

rvargas (doing something else)

9 years, 5 months ago (2011-07-21 23:05:18 UTC) #4

Thanks

http://codereview.chromium.org/7468017/diff/1/net/http/http_cache_transaction.cc
File net/http/http_cache_transaction.cc (right):

http://codereview.chromium.org/7468017/diff/1/net/http/http_cache_transaction...
net/http/http_cache_transaction.cc:1281: // Balanced in
DoCacheQueryDataComplete.
On 2011/07/21 22:11:23, gavinp wrote:
> So these were just plain wrong?  Good catch.  And my apologies if I missed
that
> in a review.

Left behind by some refactor.

Expand Messages | Collapse Messages