Issue 7468010: RenderViewHostDelegate: add missing 'virtual'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7468010: RenderViewHostDelegate: add missing 'virtual' (Closed)

Created:
9 years, 5 months ago by Evan Martin

Modified:
9 years, 5 months ago

Reviewers:
tony, levin, jam, Dmitry Titov

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

RenderViewHostDelegate: add missing 'virtual' Nobody was getting notified when workers crash. (This was caught by a further patch of mine that adds OVERRIDE to users of this file, which would have caught this.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93438

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages