Modifying prefetch to account for multi-profile.

chrome/browser/io_thread.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/debug/leak_tracker.h"
@@ skipping 300 matching lines @@
 // |local_state| is passed in explicitly in order to (1) reduce implicit
 // dependencies and (2) make IOThread more flexible for testing.
 IOThread::IOThread(
     PrefService* local_state,
     ChromeNetLog* net_log,
     ExtensionEventRouterForwarder* extension_event_router_forwarder)
     : BrowserProcessSubThread(BrowserThread::IO),
       net_log_(net_log),
       extension_event_router_forwarder_(extension_event_router_forwarder),
       globals_(NULL),
-      speculative_interceptor_(NULL),
-      predictor_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)) {
   // We call RegisterPrefs() here (instead of inside browser_prefs.cc) to make
   // sure that everything is initialized in the right order.
   RegisterPrefs(local_state);
   auth_schemes_ = local_state->GetString(prefs::kAuthSchemes);
   negotiate_disable_cname_lookup_ = local_state->GetBoolean(
       prefs::kDisableAuthNegotiateCnameLookup);
   negotiate_enable_port_ = local_state->GetBoolean(
       prefs::kEnableAuthNegotiatePort);
   auth_server_whitelist_ = local_state->GetString(prefs::kAuthServerWhitelist);
@@ skipping 27 matching lines @@
 ChromeNetLog* IOThread::net_log() {
   return net_log_;
 }
 
 void IOThread::InitNetworkPredictor(
     bool prefetching_enabled,
     base::TimeDelta max_dns_queue_delay,
     size_t max_speculative_parallel_resolves,
     const chrome_common_net::UrlList& startup_urls,
     ListValue* referral_list,
+    Profile* profile,
     bool preconnect_enabled) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   message_loop()->PostTask(
       FROM_HERE,
       NewRunnableMethod(
           this,
           &IOThread::InitNetworkPredictorOnIOThread,
           prefetching_enabled, max_dns_queue_delay,
           max_speculative_parallel_resolves,
-          startup_urls, referral_list, preconnect_enabled));
+          startup_urls, referral_list, preconnect_enabled, profile));
 }
 
 void IOThread::RegisterURLRequestContextGetter(
     ChromeURLRequestContextGetter* url_request_context_getter) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   std::list<ChromeURLRequestContextGetter*>::const_iterator it =
       std::find(url_request_context_getters_.begin(),
                 url_request_context_getters_.end(),
                 url_request_context_getter);
   DCHECK(it == url_request_context_getters_.end());
   url_request_context_getters_.push_back(url_request_context_getter);
 }
 
 void IOThread::UnregisterURLRequestContextGetter(
     ChromeURLRequestContextGetter* url_request_context_getter) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   std::list<ChromeURLRequestContextGetter*>::iterator it =
       std::find(url_request_context_getters_.begin(),
                 url_request_context_getters_.end(),
                 url_request_context_getter);
   DCHECK(it != url_request_context_getters_.end());
   // This does not scale, but we shouldn't have many URLRequestContextGetters in
   // the first place, so this should be fine.
   url_request_context_getters_.erase(it);
 }
 
-void IOThread::ChangedToOnTheRecord() {
+void IOThread::ChangedToOnTheRecord(Profile* profile) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   message_loop()->PostTask(
       FROM_HERE,
       NewRunnableMethod(
           this,
-          &IOThread::ChangedToOnTheRecordOnIOThread));
+          &IOThread::ChangedToOnTheRecordOnIOThread,
+          profile));
 }
 
 net::URLRequestContextGetter* IOThread::system_url_request_context_getter() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!system_url_request_context_getter_) {
     InitSystemRequestContext();
   }
   return system_url_request_context_getter_;
 }
 
-void IOThread::ClearNetworkingHistory() {
+void IOThread::ClearNetworkingHistory(
+    chrome_browser_net::Predictor* predictor) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   ClearHostCache();
   // Discard acrued data used to speculate in the future.
-  chrome_browser_net::DiscardInitialNavigationHistory();
-  if (predictor_)
-    predictor_->DiscardAllResults();
+  if (predictor) {
+    predictor->DiscardInitialNavigationHistory();
+    predictor->DiscardAllResults();
+  }
 }
 
 void IOThread::Init() {
   // Though this thread is called the "IO" thread, it actually just routes
   // messages around; it shouldn't be allowed to perform any blocking disk I/O.
   base::ThreadRestrictions::SetIOAllowed(false);
 
   BrowserProcessSubThread::Init();
 
   DCHECK_EQ(MessageLoop::TYPE_IO, message_loop()->type());
@@ skipping 83 matching lines @@
   }
 
   system_url_request_context_getter_ = NULL;
 
   // Step 2: Release objects that the net::URLRequestContext could have been
   // pointing to.
 
   // This must be reset before the ChromeNetLog is destroyed.
   network_change_observer_.reset();
 
-  // Not initialized in Init().  May not be initialized.
-  if (predictor_) {
-    predictor_->Shutdown();
-
-    // TODO(willchan): Stop reference counting Predictor.  It's owned by
-    // IOThread now.
-    predictor_->Release();
-    predictor_ = NULL;
-    chrome_browser_net::FreePredictorResources();
-  }
-
-  // Deletion will unregister this interceptor.
-  delete speculative_interceptor_;
-  speculative_interceptor_ = NULL;
-
   system_proxy_config_service_.reset();
 
   delete globals_;
   globals_ = NULL;
 
   // net::URLRequest instances must NOT outlive the IO thread.
   base::debug::LeakTracker<net::URLRequest>::CheckForLeaks();
 
   base::debug::LeakTracker<SystemURLRequestContextGetter>::CheckForLeaks();
 
@@ skipping 42 matching lines @@
       negotiate_disable_cname_lookup_,
       negotiate_enable_port_);
 }
 
 void IOThread::InitNetworkPredictorOnIOThread(
     bool prefetching_enabled,
     base::TimeDelta max_dns_queue_delay,
     size_t max_speculative_parallel_resolves,
     const chrome_common_net::UrlList& startup_urls,
     ListValue* referral_list,
-    bool preconnect_enabled) {
+    bool preconnect_enabled,
+    Profile* profile) {

[willchan no longer on Chromium, 2011/07/21 12:10:53]

Profile* is not allowed to be used on the IO thread. There is a potential race
condition with shutdown here. Profile is a UI thread only object.

This code shoudl move into Predictor initialization and should be removed from
IOThread.

[rpetterson, 2011/08/10 02:24:46]

Done.

   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  CHECK(!predictor_);
+  CHECK(!profile->GetPredictor());
 
-  chrome_browser_net::EnablePredictor(prefetching_enabled);
-
-  predictor_ = new chrome_browser_net::Predictor(
+  profile->SetPredictor(new chrome_browser_net::Predictor(
       globals_->host_resolver.get(),
       max_dns_queue_delay,
       max_speculative_parallel_resolves,
-      preconnect_enabled);
-  predictor_->AddRef();
+      preconnect_enabled,
+      prefetching_enabled));
 
-  // Speculative_interceptor_ is used to predict subresource usage.
-  DCHECK(!speculative_interceptor_);
-  speculative_interceptor_ = new chrome_browser_net::ConnectInterceptor;
-
-  FinalizePredictorInitialization(predictor_, startup_urls, referral_list);
+  profile->GetPredictor()->FinalizeInitialization(startup_urls, referral_list);
 }
 
-void IOThread::ChangedToOnTheRecordOnIOThread() {
+void IOThread::ChangedToOnTheRecordOnIOThread(Profile* profile) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  if (predictor_) {
+  if (profile->GetPredictor()) {

[willchan no longer on Chromium, 2011/07/21 12:10:53]

This should die. Once you've made the Predictor be per-Profile, and you don't
have it for incognito, there's no danger of the Predictor getting contaminated
with OTR data. Just kill this off.

[rpetterson, 2011/08/10 02:24:46]

Done.

     // Destroy all evidence of our OTR session.
     // Note: OTR mode never saves InitialNavigationHistory data.
-    predictor_->Predictor::DiscardAllResults();
+    profile->GetPredictor()->DiscardAllResults();
   }
 
   // Clear the host cache to avoid showing entries from the OTR session
   // in about:net-internals.
   ClearHostCache();
 
   // Clear all of the passively logged data.
   // TODO(eroman): this is a bit heavy handed, really all we need to do is
   //               clear the data pertaining to incognito context.
   net_log_->ClearAllPassivelyCapturedEvents();
@@ skipping 54 matching lines @@
   system_params.network_delegate = globals_->system_network_delegate.get();
   system_params.net_log = net_log_;
   globals_->system_http_transaction_factory.reset(
       new net::HttpNetworkLayer(
           new net::HttpNetworkSession(system_params)));
   globals_->system_ftp_transaction_factory.reset(
       new net::FtpNetworkLayer(globals_->host_resolver.get()));
   globals_->system_request_context =
       ConstructSystemRequestContext(globals_, net_log_);
 }