Some filebrowser bugs and retiring DiskChanged event in filebrowser

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 120 matching lines @@
 
   this.initCommands_();
   this.initDom_();
   this.initDialogType_();
   this.initDefaultDirectory_(this.params_.defaultPath);
 
   this.summarizeSelection_();
   this.updatePreview_();
 
   chrome.fileBrowserPrivate.onDiskChanged.addListener(
       this.onDiskChanged_.bind(this));

[zel, 2011/08/09 00:09:45]

why don't we remove this if this function is no longer needed?

also file a bug to remove this event from extension API as well

[tbarzic, 2011/08/09 00:35:07]

I think it would be better that we leave it in extension API for now because we
might still need it (e.g. for displaying unformatted devices, which don't get
detected with MountComplete event).

 
   this.refocus();
 
   // Pass all URLs to the metadata reader until we have a correct filter.
   this.metadataUrlFilter_ = /.*/;
 
   this.metadataReader_ = new Worker('js/metadata_dispatcher.js');
   this.metadataReader_.onmessage = this.onMetadataMessage_.bind(this);
   this.metadataReader_.postMessage({verb: 'init'});
   // Initialization is not complete until the Worker sends back the
@@ skipping 1478 matching lines @@
                 var fileName = event.sourceUrl.substr(
                     event.sourceUrl.lastIndexOf('/') + 1);
                 self.alert.show(strf('ARCHIVE_MOUNT_FAILED', fileName,
                                      event.status));
               }
             }
             return;
           }
         }
       }
+
+      if (event.eventType == 'unmount' && event.status == 'success' &&
+          self.currentDirEntry_ &&
+          isParentPath(event.mountPath, self.currentDirEntry_.fullPath)) {
+        self.changeDirectory(getParentPath(event.mountPath));
+        return;
+      }
+
       // TODO(dgozman): rescan directory, only if it contains mounted points,
       // when mounts location will be decided.
-      this.rescanDirectory_();
+      if (event.status == 'success')
+        self.rescanDirectory_();
     });
   };
 
   /**
    * Event handler called when some internal task should be executed.
    */
   FileManager.prototype.onFileTaskExecute_ = function(id, details) {
     var urls = details.entries.map(function(entry) {
         return entry.toURL();
     });
@@ skipping 710 matching lines @@
         // is loaded at this point.
         chrome.test.sendMessage('directory-change-complete');
       });
   };
 
   /**
    * Update the UI when a disk is mounted or unmounted.
    *
    * @param {string} path The path that has been mounted or unmounted.
    */
   FileManager.prototype.onDiskChanged_ = function(event) {

[zel, 2011/08/09 00:09:45]

why don't we remove this?

[tbarzic, 2011/08/09 00:35:07]

Done.

-    if (event.eventType == 'added') {
-      this.changeDirectory(event.volumeInfo.mountPath);
-    } else if (event.eventType == 'removed') {
-      if (this.currentDirEntry_ &&
-          isParentPath(event.volumeInfo.mountPath,
-                       this.currentDirEntry_.fullPath)) {
-        this.changeDirectory(getParentPath(event.volumeInfo.mountPath));
-      }
-    }
   };
 
   /**
    * Rescan the current directory, refreshing the list.
    *
    * @param {function()} opt_callback Optional function to invoke when the
    *     rescan is complete.
    */
   FileManager.prototype.rescanDirectory_ = function(opt_callback) {
     var self = this;
@@ skipping 613 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();