Some filebrowser bugs and retiring DiskChanged event in filebrowser

chrome/browser/chromeos/cros/mount_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 86 matching lines @@
     DeviceType device_type_;
     uint64 total_size_;
     bool is_parent_;
     bool is_read_only_;
     bool has_media_;
     bool on_boot_device_;
   };
   typedef std::map<std::string, Disk*> DiskMap;
   typedef std::map<std::string, std::string> PathMap;
 
-  // MountPointInfo: {mount_path, mount_type}.
   struct MountPointInfo {
     std::string source_path;
     std::string mount_path;
     MountType mount_type;
 
     MountPointInfo(const char* source, const char* mount, const MountType type)
         : source_path(source ? source : ""),
           mount_path(mount ? mount : ""),
           mount_type(type) {
     }
   };
 
-  // MountPointMap key is source_path.
+  // MountPointMap key is mount_path.
   typedef std::map<std::string, MountPointInfo> MountPointMap;
 
   typedef void(*UnmountDeviceRecursiveCallbackType)(void*, bool);
 
   class Observer {
    public:
     virtual ~Observer() {}
     // Async API events.
     virtual void DiskChanged(MountLibraryEventType event,
                              const Disk* disk) = 0;
     virtual void DeviceChanged(MountLibraryEventType event,
                                const std::string& device_path ) = 0;
     virtual void MountCompleted(MountEvent event_type,
-        MountError error_code,
-        const MountPointInfo& mount_info) = 0;
+                                MountError error_code,
+                                const MountPointInfo& mount_info) = 0;
   };
 
   virtual ~MountLibrary() {}
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
   virtual const DiskMap& disks() const = 0;
   virtual const MountPointMap& mount_points() const = 0;
 
   virtual void RequestMountInfoRefresh() = 0;
   virtual void MountPath(const char* source_path,
                          MountType type,
                          const MountPathOptions& options) = 0;
-  // |path| may be source od mount path.
+  // |path| is device's mount path.
   virtual void UnmountPath(const char* path) = 0;
 
   // Formats device given its file path.
   // Example: file_path: /dev/sdb1
   virtual void FormatUnmountedDevice(const char* file_path) = 0;
 
   // Formats Device given its mount path. Unmount's the device
   // Example: mount_path: /media/VOLUME_LABEL
   virtual void FormatMountedDevice(const char* mount_path) = 0;
 
   // Unmounts device_poath and all of its known children.
   virtual void UnmountDeviceRecursive(const char* device_path,
       UnmountDeviceRecursiveCallbackType callback, void* user_data) = 0;
 
   // Helper functions for parameter conversions.
   static std::string MountTypeToString(MountType type);
   static MountType MountTypeFromString(const std::string& type_str);
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via CrosLibrary::Get().
   static MountLibrary* GetImpl(bool stub);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_