Some filebrowser bugs and retiring DiskChanged event in filebrowser

Stopping using DiskChanged event for mount/unmount event processing in FileBrowserEventRouter and some bug fixes.

UnmountPath now expects mount_path to be passed to it.

Hiding device notification when disk added event is triggered instead when some
device is mounted (notification handleing needs some more work).

Fixed chromium-os:18339 and chromium-os:17777


BUG=chromium-os:18399, chromium-os:17531, chromium-os:17777
TEST=Made sure FileBrowser works as expected on Cr48.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96419

[tbarzic, 2011-08-08 18:37:20]

On 2011/08/03 22:37:45, toni wrote:

ping?

[zel, 2011-08-08 18:47:19]

http://codereview.chromium.org/7466046/diff/13001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7466046/diff/13001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12223: Sorry, <ph
name="DEVICE_LABEL">$1<ex>SD card</ex></ph> is not supported on your Chromebook
at this time.
string changes can't be in for M14. please take a look at the existing strings
and see if you can use some of them now instead. the message does not have to be
so verbose.

for m15, send these two sentences to Ken/Josh to approve them

[tbarzic, 2011-08-09 00:03:34]

http://codereview.chromium.org/7466046/diff/13001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7466046/diff/13001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:12223: Sorry, <ph
name="DEVICE_LABEL">$1<ex>SD card</ex></ph> is not supported on your Chromebook
at this time.
On 2011/08/08 18:47:19, zel wrote:
> string changes can't be in for M14. please take a look at the existing strings
> and see if you can use some of them now instead. the message does not have to
be
> so verbose.
> 
> for m15, send these two sentences to Ken/Josh to approve them  

Done.

[zel, 2011-08-09 00:09:45]

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/mount_library.cc (left):

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/mount_library.cc:333: void OnUnmountPath(const
char* source_path,
is this param now really mount_path? or is it mount_source_path?

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:141:
this.onDiskChanged_.bind(this));
why don't we remove this if this function is no longer needed?

also file a bug to remove this event from extension API as well

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:2382:
FileManager.prototype.onDiskChanged_ = function(event) {
why don't we remove this?

[tbarzic, 2011-08-09 00:35:06]

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/mount_library.cc (left):

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/mount_library.cc:333: void OnUnmountPath(const
char* source_path,
On 2011/08/09 00:09:45, zel wrote:
> is this param now really mount_path? or is it mount_source_path?

Its really mount_path.. calling with source path does unmount device, but
GetMountPoints does not work fine with it..

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:141:
this.onDiskChanged_.bind(this));
On 2011/08/09 00:09:45, zel wrote:
> why don't we remove this if this function is no longer needed?
> 
> also file a bug to remove this event from extension API as well

I think it would be better that we leave it in extension API for now because we
might still need it (e.g. for displaying unformatted devices, which don't get
detected with MountComplete event).

http://codereview.chromium.org/7466046/diff/21008/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:2382:
FileManager.prototype.onDiskChanged_ = function(event) {
On 2011/08/09 00:09:45, zel wrote:
> why don't we remove this?

Done.

[zel, 2011-08-11 01:09:18]

LGTM