Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 7466030: Remove default proxy service tweaking in ChromeOS login. (Closed)

Created:
9 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove default proxy service tweaking in ChromeOS login. Proxy policy is also pushed through local_state, so we don't need this hack any longer. BUG=None TEST=Compiles and passes tests, ChromeOS login works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 4 chunks +1 line, -55 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mattias Nissler (ping if slow)
Joao: Please review. Only deletions! Will: FYI.
9 years, 5 months ago (2011-07-21 10:27:08 UTC) #1
Mattias Nissler (ping if slow)
On 2011/07/21 10:27:08, Mattias Nissler wrote: > Joao: Please review. Only deletions! > Will: FYI. ...
9 years, 5 months ago (2011-07-21 11:10:07 UTC) #2
Mattias Nissler (ping if slow)
Thinking about this even more, we actually can just remove this. Our policy providers are ...
9 years, 5 months ago (2011-07-22 12:42:11 UTC) #3
pastarmovj
This looks even better to me than the hack - LBTM! (and because I am ...
9 years, 5 months ago (2011-07-22 12:53:25 UTC) #4
Mattias Nissler (ping if slow)
Nikita, can you give me OWNERS approval?
9 years, 5 months ago (2011-07-22 12:53:57 UTC) #5
altimofeev
LGTM
9 years, 5 months ago (2011-07-22 14:19:19 UTC) #6
commit-bot: I haz the power
9 years, 5 months ago (2011-07-22 15:38:43 UTC) #7
Change committed as 93634

Powered by Google App Engine
This is Rietveld 408576698