Issue 7466017: Fixes crash introduced by fix for 11229. The fix for 11229 made it so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7466017: Fixes crash introduced by fix for 11229. The fix for 11229 made it so (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes crash introduced by fix for 11229. The fix for 11229 made it so we might pass a bounds and maximized request when creating a browser window. If for whatever reason that size isn't valid (say doesn't fit on the monitor), then CreateWindow calls WM_POSCHANGED. The current code didn't handle this too well because not all the state has been set up yet. BUG=89843 TEST=none R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93319

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporate review feedback #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_view.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	M	views/widget/widget.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

9 years, 5 months ago (2011-07-20 23:09:40 UTC) #2

LGTM, but we might want comments in these spots saying when/why they can be
NULL, if that's not blindingly obvious to a future code spelunker

http://codereview.chromium.org/7466017/diff/1/views/widget/widget.h
File views/widget/widget.h (right):

http://codereview.chromium.org/7466017/diff/1/views/widget/widget.h#newcode485
views/widget/widget.h:485: return non_client_view() ?
non_client_view()->client_view() : NULL;
Nit: Might as well use |non_client_view_| directly instead of the accessor

Expand Messages | Collapse Messages