Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: ppapi/c/ppp_instance.h

Issue 7466008: Reland http://codereview.chromium.org/7452002/ again (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/pp_input_event.h ('k') | ppapi/cpp/instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/ppp_instance.h
diff --git a/ppapi/c/ppp_instance.h b/ppapi/c/ppp_instance.h
index f38f0ae778c93168af4e984d1402ef84a44cc374..31f93a35bbc51fb999eb379a21078b5c56db91c4 100644
--- a/ppapi/c/ppp_instance.h
+++ b/ppapi/c/ppp_instance.h
@@ -38,8 +38,8 @@
* to handle events such as change of focus or input events (keyboard/mouse)
* events.
*/
-#define PPP_INSTANCE_INTERFACE_0_5 "PPP_Instance;0.5"
-#define PPP_INSTANCE_INTERFACE PPP_INSTANCE_INTERFACE_0_5
+#define PPP_INSTANCE_INTERFACE_1_0 "PPP_Instance;1.0"
+#define PPP_INSTANCE_INTERFACE PPP_INSTANCE_INTERFACE_1_0
struct PPP_Instance {
/**
@@ -154,11 +154,13 @@ struct PPP_Instance {
* An instance's default condition is that it will not have focus.
*
* <strong>Note:</strong>Clicks on instances will give focus only if you
- * handle the click event. Return <code>true</code> from HandleInputEvent to
- * signal that the click event was handled. Otherwise the browser will bubble
- * the event and give focus to the element on the page that actually did end
- * up consuming it. If you're not getting focus, check to make sure you're
- * returning true from the mouse click in <code>HandleInputEvent</code>.
+ * handle the click event. Return <code>true</code> from
+ * <code>HandleInputEvent</code> in <code>PPP_InputEvent</code> (or use
+ * unfiltered events) to signal that the click event was handled. Otherwise,
+ * the browser will bubble the event and give focus to the element on the page
+ * that actually did end up consuming it. If you're not getting focus, check
+ * to make sure you're returning true from the mouse click in
+ * <code>HandleInputEvent</code>.
*
* @param[in] instance A <code>PP_Instance</code> indentifying the instance
* receiving the input event.
@@ -167,33 +169,6 @@ struct PPP_Instance {
*/
void (*DidChangeFocus)(PP_Instance instance, PP_Bool has_focus);
/**
- * HandleInputEvent() handles input events, such as keyboard events. This
- * function returns <code>PP_TRUE</code> if the event was handled or
- * <code>PP_FALSE</code> if it was not.
- *
- * If the event was handled, it will not be forwarded to the web page or
- * browser. If it was not handled, it will bubble according to the normal
- * rules. So it is important that a module respond accurately with whether
- * event propagation should continue.
- *
- * Event propagation also controls focus. If you handle an event like a mouse
- * event, typically the instance will be given focus. Returning false means
- * that the click will be given to a lower part of the page and your module
- * will not receive focus. This allows an instance to be partially
- * transparent, where clicks on the transparent areas will behave like clicks
- * to the underlying page.
- *
- * @param[in] instance A <code>PP_Instance</code> indentifying one instance
- * of a module.
- *
- * @param[in] event The input event.
- *
- * @return <code>PP_TRUE</code> if <code>event</code> was handled,
- * <code>PP_FALSE</code> otherwise.
- */
- PP_Bool (*HandleInputEvent)(PP_Instance instance,
- const struct PP_InputEvent* event);
- /**
* HandleDocumentLoad() is called after initialize for a full-frame
* module that was instantiated based on the MIME type of a DOMWindow
* navigation. This situation only applies to modules that are pre-registered
@@ -227,7 +202,7 @@ struct PPP_Instance {
*/
-typedef struct PPP_Instance PPP_Instance_0_5;
+typedef struct PPP_Instance PPP_Instance_1_0;
#endif /* PPAPI_C_PPP_INSTANCE_H_ */
« no previous file with comments | « ppapi/c/pp_input_event.h ('k') | ppapi/cpp/instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698