MD5Update function uses StringPiece instead of raw buffer.

base/md5.cc

 // The original file was copied from sqlite, and was in the public domain.
 // Modifications Copyright 2006 Google Inc. All Rights Reserved
 
 /*
  * This code implements the MD5 message-digest algorithm.
  * The algorithm is due to Ron Rivest.  This code was
  * written by Colin Plumb in 1993, no copyright is claimed.
  * This code is in the public domain; do with it what you wish.
  *
  * Equivalent code is available from RSA Data Security, Inc.
@@ skipping 192 matching lines @@
                 MD5Transform(ctx->buf, (uint32 *)ctx->in);
                 buf += 64;
                 len -= 64;
         }
 
         /* Handle any remaining bytes of data. */
 
         memcpy(ctx->in, buf, len);
 }
 
+// Call through to the raw pointer version.
+void MD5Update(MD5Context* context, const StringPiece& data) {

[brettw, 2011/07/20 20:26:28]

I think you should change the original function rather than having this useless
pass-through here.

+  MD5Update(context, data.data(), data.size());
+}
+
 /*
  * Final wrapup - pad to 64-byte boundary with the bit pattern
  * 1 0* (64-bit count of bits processed, MSB-first)
  */
 void MD5Final(MD5Digest* digest, MD5Context* context) {
         struct Context *ctx = (struct Context *)context;
         unsigned count;
         unsigned char *p;
 
         /* Compute number of bytes mod 64 */
@@ skipping 54 matching lines @@
   MD5Final(digest, &ctx);
 }
 
 std::string MD5String(const std::string& str) {
   MD5Digest digest;
   MD5Sum(str.data(), str.length(), &digest);
   return MD5DigestToBase16(digest);
 }
 
 }  // namespace base