Remove dependency on VectorPlatformDeviceEmf.

Remove cast to VectorPlatformDeviceEMF.

Dependencies on PlatformDevice, and its children should be minimized.

Also, added some OVERRIDE tags to touched files.

BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95427

[Jeff Timanus, 2011-08-03 21:15:51]

PTAL.

Removed the blind cast to a PlatformDevice derivative, as discussed in earlier
email thread.

[reed1, 2011-08-04 12:25:35]

Deferring to Steve and Alok. I don't really understand alpha-blend-used before
or after this change.

[alokp, 2011-08-04 16:06:54]

Steve would be the best person to review this.

http://codereview.chromium.org/7465104/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/7465104/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_win.cc:209: skia::PlatformDevice*
platform_device =skia::GetPlatformDevice(device);
nit: space after =

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h
File skia/ext/platform_device_win.h (right):

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h#...
skia/ext/platform_device_win.h:56: virtual bool AlphaBlendUsed() const { return
false; }
Could you add a comment what it means?

[vandebo (ex-Chrome), 2011-08-04 16:28:44]

LGTM after Alok's comments.

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h
File skia/ext/platform_device_win.h (right):

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h#...
skia/ext/platform_device_win.h:56: virtual bool AlphaBlendUsed() const { return
false; }
On 2011/08/04 16:06:54, Alok Priyadarshi wrote:
> Could you add a comment what it means?

In case you aren't sure... Some printers don't support alpha blending, so in
those cases, we flatten the EMF before sending it to the printer.  This flag
helps us decide if we need to do that.

[Jeff Timanus, 2011-08-04 16:30:33]

http://codereview.chromium.org/7465104/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper_win.cc (right):

http://codereview.chromium.org/7465104/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper_win.cc:209: skia::PlatformDevice*
platform_device =skia::GetPlatformDevice(device);
On 2011/08/04 16:06:54, Alok Priyadarshi wrote:
> nit: space after =

Done.

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h
File skia/ext/platform_device_win.h (right):

http://codereview.chromium.org/7465104/diff/1/skia/ext/platform_device_win.h#...
skia/ext/platform_device_win.h:56: virtual bool AlphaBlendUsed() const { return
false; }
On 2011/08/04 16:06:54, Alok Priyadarshi wrote:
> Could you add a comment what it means?

Done.