Issue 7465101: Check that all the hashes ids in the model are valid.

Issue 7465101: Check that all the hashes ids in the model are valid. (Closed)

Created:
9 years, 4 months ago by noelutz

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Brian Ryner, Garrett Casto, mattm

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Check that all the hashes ids in the model are valid. BUG=91423 TEST=ClientSideDetectionServiceTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95378

Patch Set 2 : Remove test URL #

Patch Set 3 : Avoid implicit conversion from double to float. #

Total comments: 4

Patch Set 4 : Address Matt's comments. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -2 lines)			Patch
M	chrome/browser/safe_browsing/client_side_detection_service.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_service.cc	View	1 2 3	4 chunks	+29 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_service_unittest.cc	View	1 2	2 chunks	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mattm

http://codereview.chromium.org/7465101/diff/1004/chrome/browser/safe_browsing/client_side_detection_service.cc File chrome/browser/safe_browsing/client_side_detection_service.cc (right): http://codereview.chromium.org/7465101/diff/1004/chrome/browser/safe_browsing/client_side_detection_service.cc#newcode465 chrome/browser/safe_browsing/client_side_detection_service.cc:465: /* static */ // style comments http://codereview.chromium.org/7465101/diff/1004/chrome/browser/safe_browsing/client_side_detection_service.cc#newcode468 chrome/browser/safe_browsing/client_side_detection_service.cc:468: const ...

9 years, 4 months ago (2011-08-03 20:46:55 UTC) #2

noelutz

Thanks, noe. http://codereview.chromium.org/7465101/diff/1004/chrome/browser/safe_browsing/client_side_detection_service.cc File chrome/browser/safe_browsing/client_side_detection_service.cc (right): http://codereview.chromium.org/7465101/diff/1004/chrome/browser/safe_browsing/client_side_detection_service.cc#newcode465 chrome/browser/safe_browsing/client_side_detection_service.cc:465: /* static */ On 2011/08/03 20:46:55, mattm ...

9 years, 4 months ago (2011-08-03 20:51:53 UTC) #3

Change committed as 95378

Expand Messages | Collapse Messages