Issue 7465098: Sync UI: Fix issue when clicking sync error link twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7465098: Sync UI: Fix issue when clicking sync error link twice. (Closed)

Created:
9 years, 4 months ago by binji

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Sync UI: Fix issue when clicking sync error link twice. BUG=90774 TEST=When "Personal Options" page has error, click error link twice. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95455

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
M	chrome/browser/sync/sync_setup_flow.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_setup_wizard.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Nicolas Zea

This doesn't address the issue of the sync error link not opening the sync setup ...

9 years, 4 months ago (2011-08-03 20:02:35 UTC) #2

binji

On 2011/08/03 20:02:35, nzea wrote: > This doesn't address the issue of the sync error ...

9 years, 4 months ago (2011-08-03 21:04:27 UTC) #3

Change committed as 95455