Minor bugs in Exif parser.

chrome/browser/resources/file_manager/js/byte_reader.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ByteReader = function(arrayBuffer) {
   this.buf_ = arrayBuffer;
   this.view_ = new DataView(arrayBuffer);
   this.pos_ = 0;
   this.seekStack_ = [];
   this.setByteOrder(ByteReader.BIG_ENDIAN);
@@ skipping 106 matching lines @@
 
   return rv.join('');
 };
 
 /**
  * Read as an image encoded in a data url.
  *
  * This is a static utility function.  There is a member function with the
  * same name which side-effects the current read position.
  */
-ByteReader.readImage = function(dataView, pos, size,
-                                opt_littleEndian, opt_end) {
+ByteReader.readImage = function(dataView, pos, size, opt_end) {
   opt_end = opt_end || dataView.byteLength;
   ByteReader.validateRead(pos, size, opt_end);
 
   var format;
   if (ByteReader.readString(dataView, pos, 4, opt_end) == '\x89PNG') {
     format = 'png';
-  } else if (dataView.getUint16(pos, opt_littleEndian) == 0xFFD8) {
+  } else if (dataView.getUint16(pos, false) == 0xFFD8) {  // Always big endian.
     format = 'jpeg';
   } else {
     format = 'unknown';
   }
 
   var b64 = ByteReader.readBase64(dataView, pos, size, opt_end);
   return 'data:image/' + format + ';base64,' + b64;
 };
 
 // Instance methods.
@@ skipping 137 matching lines @@
   return rv;
 };
 
 /**
  * Read an image returning it as a data url.
  *
  * Adjusts the current position on success.  Throws an exception if the
  * read would go past the end of the buffer.
  */
 ByteReader.prototype.readImage = function(size, opt_end) {
-  var rv = ByteReader.readImage(
-      this.view_, this.pos_, size, this.littleEndian_, opt_end);
+  var rv = ByteReader.readImage(this.view_, this.pos_, size, opt_end);
   this.pos_ += size;
   return rv;
 };
 
 /**
  * Seek to a give position relative to opt_seekStart.
  */
 ByteReader.prototype.seek = function(pos, opt_seekStart, opt_end) {
   opt_end = opt_end || this.view_.byteLength;
 
@@ skipping 31 matching lines @@
 ByteReader.prototype.popSeek = function() {
   this.seek(this.seekStack_.pop());
 };
 
 /**
  * Return the current read position.
  */
 ByteReader.prototype.tell = function() {
   return this.pos_;
 };