Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/hydrogen.cc

Issue 7465078: Check phi uses of the arguments object after redundant phies elimination. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: revert change Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2293 matching lines...) Expand 10 before | Expand all | Expand 10 after
2304 if (current_block() != NULL) { 2304 if (current_block() != NULL) {
2305 HReturn* instr = new(zone()) HReturn(graph()->GetConstantUndefined()); 2305 HReturn* instr = new(zone()) HReturn(graph()->GetConstantUndefined());
2306 current_block()->FinishExit(instr); 2306 current_block()->FinishExit(instr);
2307 set_current_block(NULL); 2307 set_current_block(NULL);
2308 } 2308 }
2309 } 2309 }
2310 2310
2311 graph()->OrderBlocks(); 2311 graph()->OrderBlocks();
2312 graph()->AssignDominators(); 2312 graph()->AssignDominators();
2313 graph()->PropagateDeoptimizingMark(); 2313 graph()->PropagateDeoptimizingMark();
2314 graph()->EliminateRedundantPhis();
2314 if (!graph()->CheckPhis()) { 2315 if (!graph()->CheckPhis()) {
2315 Bailout("Unsupported phi use of arguments object"); 2316 Bailout("Unsupported phi use of arguments object");
2316 return NULL; 2317 return NULL;
2317 } 2318 }
2318 graph()->EliminateRedundantPhis();
2319 if (FLAG_eliminate_dead_phis) graph()->EliminateUnreachablePhis(); 2319 if (FLAG_eliminate_dead_phis) graph()->EliminateUnreachablePhis();
2320 if (!graph()->CollectPhis()) { 2320 if (!graph()->CollectPhis()) {
2321 Bailout("Unsupported phi use of uninitialized constant"); 2321 Bailout("Unsupported phi use of uninitialized constant");
2322 return NULL; 2322 return NULL;
2323 } 2323 }
2324 2324
2325 HInferRepresentation rep(graph()); 2325 HInferRepresentation rep(graph());
2326 rep.Analyze(); 2326 rep.Analyze();
2327 2327
2328 if (FLAG_use_range) { 2328 if (FLAG_use_range) {
(...skipping 4417 matching lines...) Expand 10 before | Expand all | Expand 10 after
6746 } 6746 }
6747 } 6747 }
6748 6748
6749 #ifdef DEBUG 6749 #ifdef DEBUG
6750 if (graph_ != NULL) graph_->Verify(); 6750 if (graph_ != NULL) graph_->Verify();
6751 if (allocator_ != NULL) allocator_->Verify(); 6751 if (allocator_ != NULL) allocator_->Verify();
6752 #endif 6752 #endif
6753 } 6753 }
6754 6754
6755 } } // namespace v8::internal 6755 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698