Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 7465066: Fix GC problem with ToBooleanStub (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/code-stubs.h ('K') | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1417 __ j(not_equal, &call_stub, Label::kNear); 1417 __ j(not_equal, &call_stub, Label::kNear);
1418 __ fldz(); 1418 __ fldz();
1419 __ fld_d(FieldOperand(reg, HeapNumber::kValueOffset)); 1419 __ fld_d(FieldOperand(reg, HeapNumber::kValueOffset));
1420 __ FCmp(); 1420 __ FCmp();
1421 __ j(zero, false_label); 1421 __ j(zero, false_label);
1422 __ jmp(true_label); 1422 __ jmp(true_label);
1423 1423
1424 // The conversion stub doesn't cause garbage collections so it's 1424 // The conversion stub doesn't cause garbage collections so it's
1425 // safe to not record a safepoint after the call. 1425 // safe to not record a safepoint after the call.
1426 __ bind(&call_stub); 1426 __ bind(&call_stub);
1427 ToBooleanStub stub(eax); 1427 ToBooleanStub stub(eax, ToBooleanStub::all_types());
1428 __ pushad(); 1428 __ pushad();
1429 __ push(reg); 1429 __ push(reg);
1430 __ CallStub(&stub); 1430 __ CallStub(&stub);
1431 __ test(eax, Operand(eax)); 1431 __ test(eax, Operand(eax));
1432 __ popad(); 1432 __ popad();
1433 EmitBranch(true_block, false_block, not_zero); 1433 EmitBranch(true_block, false_block, not_zero);
1434 } 1434 }
1435 } 1435 }
1436 } 1436 }
1437 1437
(...skipping 2870 matching lines...) Expand 10 before | Expand all | Expand 10 after
4308 env->deoptimization_index()); 4308 env->deoptimization_index());
4309 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4309 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4310 } 4310 }
4311 4311
4312 4312
4313 #undef __ 4313 #undef __
4314 4314
4315 } } // namespace v8::internal 4315 } } // namespace v8::internal
4316 4316
4317 #endif // V8_TARGET_ARCH_IA32 4317 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/code-stubs.h ('K') | « src/ia32/code-stubs-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698