Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 7465066: Fix GC problem with ToBooleanStub (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 __ cmp(map, factory->heap_number_map()); 341 __ cmp(map, factory->heap_number_map());
342 __ j(equal, &patch, Label::kNear); 342 __ j(equal, &patch, Label::kNear);
343 } 343 }
344 344
345 if (types_.Contains(INTERNAL_OBJECT)) { 345 if (types_.Contains(INTERNAL_OBJECT)) {
346 // internal objects -> true 346 // internal objects -> true
347 __ Set(tos_, Immediate(1)); 347 __ Set(tos_, Immediate(1));
348 __ ret(1 * kPointerSize); 348 __ ret(1 * kPointerSize);
349 } 349 }
350 350
351 __ bind(&patch); 351 if (types_.ToByte() != kAllTypes) {
352 GenerateTypeTransition(masm); 352 __ bind(&patch);
353 GenerateTypeTransition(masm);
354 }
353 } 355 }
354 356
355 357
356 void ToBooleanStub::CheckOddball(MacroAssembler* masm, 358 void ToBooleanStub::CheckOddball(MacroAssembler* masm,
357 Type type, 359 Type type,
358 Handle<Object> value, 360 Handle<Object> value,
359 bool result, 361 bool result,
360 Label* patch) { 362 Label* patch) {
361 const Register argument = eax; 363 const Register argument = eax;
362 if (types_.Contains(type)) { 364 if (types_.Contains(type)) {
(...skipping 6018 matching lines...) Expand 10 before | Expand all | Expand 10 after
6381 __ Drop(1); 6383 __ Drop(1);
6382 __ ret(2 * kPointerSize); 6384 __ ret(2 * kPointerSize);
6383 } 6385 }
6384 6386
6385 6387
6386 #undef __ 6388 #undef __
6387 6389
6388 } } // namespace v8::internal 6390 } } // namespace v8::internal
6389 6391
6390 #endif // V8_TARGET_ARCH_IA32 6392 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/code-stubs.h ('K') | « src/code-stubs.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698