Fix GC problem with ToBooleanStub

src/code-stubs.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 903 matching lines @@
 
   // At most 8 different types can be distinguished, because the Code object
   // only has room for a single byte to hold a set of these types. :-P
   STATIC_ASSERT(NUMBER_OF_TYPES <= 8);
 
   class Types {
    public:
     Types() {}
     explicit Types(byte bits) : set_(bits) {}
 
     bool IsEmpty() const { return set_.IsEmpty(); }

[Vitaly Repeshko, 2011/07/27 14:49:38]

Maybe add IsAll()?

[fschneider, 2011/07/27 14:56:19]

Done.

     bool Contains(Type type) const { return set_.Contains(type); }
     void Add(Type type) { set_.Add(type); }
     byte ToByte() const { return set_.ToIntegral(); }
     void Print(StringStream* stream);
     void TraceTransition(Types to);
     bool Record(Handle<Object> object);
 
    private:
     EnumSet<Type, byte> set_;
   };
 
   static Types no_types() { return Types(); }
+  static const byte kAllTypes = 0xff;
+  static Types all_types() { return Types(kAllTypes); }

[Sven Panne, 2011/07/27 14:46:33]

Removing kAllTypes and directly using

 (1 << NUMBER_OF_TYPES) - 1

in all_types() looks a bit cleaner, I think.

[Vitaly Repeshko, 2011/07/27 14:49:38]

I agree.

[fschneider, 2011/07/27 14:56:19]

Done.

 
   explicit ToBooleanStub(Register tos, Types types = Types())
       : tos_(tos), types_(types) { }
 
   void Generate(MacroAssembler* masm);
   virtual int GetCodeKind() { return Code::TO_BOOLEAN_IC; }
   virtual void PrintName(StringStream* stream);
 
  private:
   Major MajorKey() { return ToBoolean; }
@@ skipping 10 matching lines @@
                     Label* patch);
   void GenerateTypeTransition(MacroAssembler* masm);
 
   Register tos_;
   Types types_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODE_STUBS_H_