Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4815)

Unified Diff: chrome/browser/printing/print_job_unittest.cc

Issue 7465041: GTTF: Use a fresh TestingBrowserProcess for each test, part #4 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_job_unittest.cc
diff --git a/chrome/browser/printing/print_job_unittest.cc b/chrome/browser/printing/print_job_unittest.cc
index 4ca676c8dcf39613c374b7bb567bad42452bd308..9e3487531da931e3a6aa5f2cab29ee12bdbcae71 100644
--- a/chrome/browser/printing/print_job_unittest.cc
+++ b/chrome/browser/printing/print_job_unittest.cc
@@ -7,6 +7,7 @@
#include "chrome/browser/printing/print_job.h"
#include "chrome/browser/printing/print_job_worker.h"
#include "chrome/common/chrome_notification_types.h"
+#include "chrome/test/testing_browser_process_test.h"
#include "content/common/notification_registrar.h"
#include "content/common/notification_service.h"
#include "googleurl/src/gurl.h"
@@ -80,13 +81,15 @@ class TestPrintNotifObserv : public NotificationObserver {
virtual void Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
- EXPECT_FALSE(true);
+ ADD_FAILURE();
}
};
} // namespace
-TEST(PrintJobTest, SimplePrint) {
+typedef TestingBrowserProcessTest PrintJobTest;
+
+TEST_F(PrintJobTest, SimplePrint) {
// Test the multi-threaded nature of PrintJob to make sure we can use it with
// known lifetime.
@@ -108,7 +111,7 @@ TEST(PrintJobTest, SimplePrint) {
EXPECT_TRUE(check);
}
-TEST(PrintJobTest, SimplePrintLateInit) {
+TEST_F(PrintJobTest, SimplePrintLateInit) {
volatile bool check = false;
MessageLoop current;
scoped_refptr<printing::PrintJob> job(new TestPrintJob(&check));
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_unittest.cc ('k') | chrome/browser/renderer_host/web_cache_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698