Adding UMA stats support for file open events.

chrome/browser/extensions/file_manager_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/extensions/file_manager_util.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/media/media_player.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/user_metrics.h"
@@ skipping 23 matching lines @@
 #if defined(GOOGLE_CHROME_BUILD)
     ".3gp", ".avi", ".mp3", ".mp4", ".m4v", ".mov", ".m4a",
 #endif
     ".flac", ".ogm", ".ogv", ".ogx", ".ogg", ".oga", ".wav", ".webm",
 /* TODO(zelidrag): Add unsupported ones as we enable them:
     ".mkv", ".divx", ".xvid", ".wmv", ".asf", ".mpeg", ".mpg",
     ".wma", ".aiff",
 */
 };
 
+// List of all extensions we want to be shown in histogram that keep track of
+// files that were unsuccessfully tried to be opened.
+// The list has to be synced with histogram values.
+const char* kUMATrackingExtensions[] = {
+  ".doc", ".docx", ".ppt", ".pptx", ".xls", ".xlsx", ".csv", ".zip", ".rar",
+  ".asf", ".wma", ".wmv", ".mov", ".avi", ".mp4", ".mpg", ".log", ".rtf",
+  ".odf", ".odp", ".ods", ".odt", ".pdf", "other"

[zel, 2011/08/01 01:39:49]

let's make "other" being the first one on the list - we will keep adding
extensions. 

try to group all documents of the same top level 'type' together. for example,
".rtf" should be right next to '.doc' and '.docx'

remove ".zip", ".avi", ".mp4" from here, we support these

[tbarzic, 2011/08/02 18:05:54]

Done.

+};
+
 bool IsSupportedBrowserExtension(const char* ext) {
   for (size_t i = 0; i < arraysize(kBrowserSupportedExtensions); i++) {
     if (base::strcasecmp(ext, kBrowserSupportedExtensions[i]) == 0) {
       return true;
     }
   }
   return false;
 }
 
 bool IsSupportedAVExtension(const char* ext) {
   for (size_t i = 0; i < arraysize(kAVExtensions); i++) {
     if (base::strcasecmp(ext, kAVExtensions[i]) == 0) {
       return true;
     }
   }
   return false;
 }
 
+// Returns index |ext| has in the |array|. If there is no |ext| in |array|, last
+// element's index is return (last element should have irrelevant value).
+int UMAExtensionIndex(const char *ext,
+                      const char** array,
+                      size_t array_size) {
+  for (size_t i = 0; i < array_size; i++) {
+    if (base::strcasecmp(ext, array[i]) == 0) {
+      return i;
+    }
+  }
+  return array_size - 1;
+}
+
 // static
 GURL FileManagerUtil::GetFileBrowserUrl() {
   return GURL(kBaseFileBrowserUrl);
 }
 
 // static
 GURL FileManagerUtil::GetMediaPlayerUrl() {
   return GURL(kMediaPlayerUrl);
 }
 
@@ skipping 79 matching lines @@
     if (!browser)
       return;
     MediaPlayer* mediaplayer = MediaPlayer::GetInstance();
     if (enqueue)
       mediaplayer->EnqueueMediaFile(browser->profile(), full_path, NULL);
     else
       mediaplayer->ForcePlayMediaFile(browser->profile(), full_path, NULL);
     return;
   }
 
-  // Unknown file type. Show an error message.
+  // Unknown file type. Record UMA and show an error message.
+  size_t extension_index = UMAExtensionIndex(ext.data(),
+                                             kUMATrackingExtensions,
+                                             arraysize(kUMATrackingExtensions));
+  UMA_HISTOGRAM_ENUMERATION("FileBrowser.OpeningFileType",

[zel, 2011/08/01 01:39:49]

you need to add this to histogram.xml file as well

[tbarzic, 2011/08/02 18:05:54]

I know

+                            extension_index,
+                            arraysize(kUMATrackingExtensions) - 1);
+
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableFunction(
           &platform_util::SimpleErrorBox,
           static_cast<gfx::NativeWindow>(NULL),
           l10n_util::GetStringUTF16(IDS_FILEBROWSER_ERROR_TITLE),
           l10n_util::GetStringFUTF16(IDS_FILEBROWSER_ERROR_UNKNOWN_FILE_TYPE,
                                      UTF8ToUTF16(full_path.BaseName().value()))
           ));
 }
@@ skipping 69 matching lines @@
     case SelectFileDialog::SELECT_OPEN_MULTI_FILE:
       type_str = "open-multi-file";
       break;
 
     default:
       NOTREACHED();
   }
 
   return type_str;
 }