Sync performance tests: Cleanup TODOs and print in dashboard friendly format

chrome/test/live_sync/performance/passwords_sync_perf_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stringprintf.h"
 #include "chrome/browser/password_manager/password_store.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/test/live_sync/live_passwords_sync_test.h"
 #include "chrome/test/live_sync/performance/sync_timing_helper.h"
 
+// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
+// datatypes into a performance test base class, once it is possible to do so.
 static const int kNumPasswords = 150;
-
-// TODO(braffert): Consider the range / resolution of these test points.
 static const int kNumBenchmarkPoints = 18;
 static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
                                        150, 175, 200, 225, 250, 300, 350, 400,
                                        500};
 
-// TODO(braffert): Move this class into its own .h/.cc files.  What should the
-// class files be named as opposed to the file containing the tests themselves?
 class PasswordsSyncPerfTest
     : public TwoClientLivePasswordsSyncTest {
  public:
   PasswordsSyncPerfTest() : password_number_(0) {}
 
   // Adds |num_logins| new unique passwords to |profile|.
   void AddLogins(int profile, int num_logins);
 
   // Updates the password for all logins for |profile|.
   void UpdateLogins(int profile);
@@ skipping 55 matching lines @@
 // TCM ID - 7567749.
 IN_PROC_BROWSER_TEST_F(PasswordsSyncPerfTest, Add) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddLogins(0, kNumPasswords);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(kNumPasswords, GetPasswordCount(0));
   ASSERT_TRUE(AllProfilesContainSamePasswordForms());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("passwords", "add", dt);
 }
 
 // TCM ID - 7365093.
 IN_PROC_BROWSER_TEST_F(PasswordsSyncPerfTest, Update) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddLogins(0, kNumPasswords);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   UpdateLogins(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(kNumPasswords, GetPasswordCount(0));
   ASSERT_TRUE(AllProfilesContainSamePasswordForms());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("passwords", "update", dt);
 }
 
 // TCM ID - 7557852.
 IN_PROC_BROWSER_TEST_F(PasswordsSyncPerfTest, Delete) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddLogins(0, kNumPasswords);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   RemoveLogins(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(0, GetPasswordCount(0));
   ASSERT_TRUE(AllProfilesContainSamePasswordForms());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("passwords", "delete", dt);
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordsSyncPerfTest, DISABLED_Benchmark) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   for (int i = 0; i < kNumBenchmarkPoints; ++i) {
     int num_passwords = kBenchmarkPoints[i];
     AddLogins(0, num_passwords);
     base::TimeDelta dt_add =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
@@ skipping 14 matching lines @@
     base::TimeDelta dt_delete =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
     ASSERT_EQ(0, GetPasswordCount(0));
     ASSERT_TRUE(AllProfilesContainSamePasswordForms());
     VLOG(0) << std::endl << "Delete: " << num_passwords << " "
             << dt_delete.InSecondsF();
 
     Cleanup();
   }
 }