Sync performance tests: Cleanup TODOs and print in dashboard friendly format

chrome/test/live_sync/performance/autofill_sync_perf_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stringprintf.h"
 #include "chrome/browser/autofill/autofill_common_test.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/test/live_sync/live_autofill_sync_test.h"
 #include "chrome/test/live_sync/performance/sync_timing_helper.h"
 
 static const int kNumProfiles = 150;
-
-// TODO(braffert): Consider the range / resolution of these test points.

[Raghu Simha, 2011/07/26 06:19:45]

Perhaps replace this with a TODO for moving kBenchmarkPoints and
kNumBenchmarkPoints into a performance test base class once it's possible to
create one?

[braffert, 2011/07/26 17:46:59]

Done.

 static const int kNumBenchmarkPoints = 18;
 static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
                                        150, 175, 200, 225, 250, 300, 350, 400,
                                        500};
 
-// TODO(braffert): Move this class into its own .h/.cc files.  What should the
-// class files be named as opposed to the file containing the tests themselves?

[Raghu Simha, 2011/07/26 06:19:45]

Curious: You're deleting the TODO to move the class into its own .h/.cc file,
but the class hasn't actually moved. Do you still intend to do so? (I'm OK with
them being left as they are, instead of tripling the number of files)

[braffert, 2011/07/26 17:46:59]

That's what I was thinking as well - currently there would be no benefit from
separating each datatype into three files.  Though it may be a good idea to move
all the datatype specific convenience methods into a single performance helper
class, but this is best left for a later time.  

 class AutofillSyncPerfTest
     : public TwoClientLiveAutofillSyncTest {
  public:
   AutofillSyncPerfTest() : guid_number_(0), name_number_(0) {}
 
   // Adds |num_profiles| new autofill profiles to the sync profile |profile|.
   void AddProfiles(int profile, int num_profiles);
 
   // Updates all autofill profiles for the sync profile |profile|.
   void UpdateProfiles(int profile);
@@ skipping 89 matching lines @@
 // TCM ID - 7557873.
 IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Add) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddProfiles(0, kNumProfiles);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(kNumProfiles, GetProfileCount(0));
   ASSERT_TRUE(AllProfilesMatch());
 
-  // TODO(braffert): Compare timings against some target value.

[Raghu Simha, 2011/07/26 06:19:45]

Don't you still have to compare the timings? I don't see PrintResult doing so.

[braffert, 2011/07/26 17:46:59]

The tracking and comparison is done automatically by the perf dashboard.  This
just prints the timings in a format that matches the dashboard's expectations.

-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("autofill", "add", dt);
 }
 
 // TCM ID - 7549835.
 IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Update) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddProfiles(0, kNumProfiles);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   UpdateProfiles(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(kNumProfiles, GetProfileCount(0));
   ASSERT_TRUE(AllProfilesMatch());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("autofill", "update", dt);
 }
 
 // TCM ID - 7553678.
 IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Delete) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   AddProfiles(0, kNumProfiles);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   RemoveProfiles(0);
   base::TimeDelta dt =
       SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
   ASSERT_EQ(0, GetProfileCount(0));
   ASSERT_TRUE(AllProfilesMatch());
 
-  // TODO(braffert): Compare timings against some target value.
-  VLOG(0) << std::endl << "dt: " << dt.InSecondsF() << " s";
+  SyncTimingHelper::PrintResult("autofill", "delete", dt);
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, DISABLED_Benchmark) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   for (int i = 0; i < kNumBenchmarkPoints; ++i) {
     int num_profiles = kBenchmarkPoints[i];
     AddProfiles(0, num_profiles);
     base::TimeDelta dt_add =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
@@ skipping 14 matching lines @@
     base::TimeDelta dt_delete =
         SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
     ASSERT_EQ(0, GetProfileCount(0));
     ASSERT_TRUE(AllProfilesMatch());
     VLOG(0) << std::endl << "Delete: " << num_profiles << " "
             << dt_delete.InSecondsF();
 
     Cleanup();
   }
 }