Integrate syzygy (optionally) into the chrome build process.

chrome/syzygy.gypi

Index: chrome/syzygy.gypi
===================================================================
--- chrome/syzygy.gypi	(revision 0)
+++ chrome/syzygy.gypi	(revision 0)
@@ -0,0 +1,80 @@
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'variables': {
+    'optimize_with_syzygy%': 0,
+  },
+  'conditions': [
+    ['OS=="win"', {
+      'targets': [
+        {
+          'target_name': 'chrome_dll',

[M-A Ruel, 2011/08/03 17:32:59]

I still don't like having this target in a separate file. It makes maintenance
significantly more confusing. What is the goal of putting this in a separate
file?

[Roger McFarlane (Google), 2011/08/03 17:56:35]

Merging this into chrome_dll.gypi would introduce a circular depencency in the
includes. The optimization step involves launching chrome and profiling its
startup. So, it depends on chrome and on the initial chrome_dll. chrome also
depends on the initial chrome_dll.

+          'type': 'none',
+          'sources' : [],
+          'dependencies': [
+            'chrome_dll_initial',
+            'chrome',
+          ],
+          'conditions': [
+            ['optimize_with_syzygy==1', {
+              # Optimize the initial chrome DLL and PDB files, placing the
+              # optimized output into the product directory.
+              'actions': [
+                {
+                  'inputs': [
+                    '<(PRODUCT_DIR)\\initial\\chrome.dll',
+                    '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
+                  ],
+                  'outputs': [
+                    '<(PRODUCT_DIR)\\chrome.dll',
+                    '<(PRODUCT_DIR)\\chrome_dll.pdb',
+                  ],
+                  'action_name': 'Optimize Chrome binaries with syzygy',
+                  'msvs_cygwin_shell': 0,
+                  'action': [
+                    '<(DEPTH)\\third_party\\syzygy\\binaries\\optimize.bat',
+                    '--verbose',
+                    '--input-dir="<(PRODUCT_DIR)"',
+                    '--input-dll="<(PRODUCT_DIR)\\initial\\chrome.dll"',
+                    '--input-pdb="<(PRODUCT_DIR)\\initial\\chrome_dll.pdb"',
+                    '--output-dir="<(INTERMEDIATE_DIR)\\optimized"',
+                    '--copy-to="<(PRODUCT_DIR)"',
+                  ],
+                }
+              ],
+            }, {
+              # optimize_with_syzygy != 1            
+              # Simply copy the chrome DLL and PDB files into the product
+              # directory.
+              'actions': [
+                {
+                  'action_name': 'Copy chrome.dll to product directory',
+                  'msvs_cygwin_shell': 0,
+                  'variables': {
+                    'input': '<(PRODUCT_DIR)\\initial\\chrome.dll',
+                    'output': '<(PRODUCT_DIR)\\chrome.dll',
+                  },
+                  'inputs': ['<(input)'],
+                  'outputs': ['<(output)'],
+                  'action': ['copy', '<(input)', '<(output)'],

[chrisha, 2011/08/03 17:16:27]

There's a 'copies' functionality built in to GYP. Check out
http://codesearch.google.com/#OAMlx_jo-ck/o3d/build/libs.gyp&exact_package=ch...
for an example.

[M-A Ruel, 2011/08/03 17:32:59]

hardlink ftw?

[Roger McFarlane (Google), 2011/08/03 17:56:35]

Excellent! Thanks for the tip.

[Roger McFarlane (Google), 2011/08/03 17:56:35]

Please elucidate?

:)

Not sure a hard link would be ideal if we want to support changing an existing
dev environment between modes (i.e., developer sets
GYP_DEFINES=optimize_with_syzygy=1 and reruns the hooks).

[Roger McFarlane (Google), 2011/08/03 18:22:18]

Done.

[Roger McFarlane (Google), 2011/08/03 18:22:18]

Siggi's reply seems to have vanished into the ether ...

siggi: I'm wary of hardlinks on Windows, is there anything wrong with a copy?

+                },
+                {
+                  'action_name': 'Copy chrome_dll.pdb to product directory',
+                  'msvs_cygwin_shell': 0,
+                  'variables': {
+                    'input': '<(PRODUCT_DIR)\\initial\\chrome_dll.pdb',
+                    'output': '<(PRODUCT_DIR)\\chrome_dll.pdb',
+                  },
+                  'inputs': ['<(input)'],
+                  'outputs': ['<(output)'],
+                  'action': ['copy', '<(input)', '<(output)'],
+                },
+              ],
+            }],
+          ], # conditions
+        },
+      ],
+    }],
+  ],
+}
Property changes on: chrome\syzygy.gypi
___________________________________________________________________
Added: svn:eol-style
   + LF