Removal of Profile from content part 1.

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 397 matching lines @@
   return handled;
 }
 
 void AutofillManager::OnFormSubmitted(const FormData& form) {
   // Let AutoComplete know as well.
   tab_contents_wrapper_->autocomplete_history_manager()->OnFormSubmitted(form);
 
   if (!IsAutofillEnabled())
     return;
 
-  if (tab_contents()->profile()->IsOffTheRecord())
+  if (tab_contents()->browser_context()->IsOffTheRecord())
     return;
 
   // Don't save data that was submitted through JavaScript.
   if (!form.user_submitted)
     return;
 
   // Grab a copy of the form data.
   FormStructure submitted_form(form);
 
   // Disregard forms that we wouldn't ever autofill in the first place.
@@ skipping 260 matching lines @@
   // positives and to avoid wasting memory.
   if (autofilled_form_signatures_.size() > kMaxRecentFormSignaturesToRemember)
     autofilled_form_signatures_.pop_back();
 
   host->Send(new AutofillMsg_FormDataFilled(
       host->routing_id(), query_id, result));
 }
 
 void AutofillManager::OnShowAutofillDialog() {
   Browser* browser = BrowserList::GetLastActiveWithProfile(
-      tab_contents()->profile());
+      static_cast<Profile*>(tab_contents()->browser_context()));

[Ilya Sherman, 2011/07/21 22:29:23]

I really don't like that clients need to magically know that this cast is safe. 
If it's always safe, can we just push it into
BrowserList::GetLastActiveWithProfile()?

   if (browser)
     browser->ShowOptionsTab(chrome::kAutofillSubPage);
 }
 
 void AutofillManager::OnDidFillAutofillFormData() {
   NotificationService::current()->Notify(
       chrome::NOTIFICATION_AUTOFILL_DID_FILL_FORM_DATA,
       Source<RenderViewHost>(tab_contents()->render_view_host()),
       NotificationService::NoDetails());
 }
@@ skipping 28 matching lines @@
 void AutofillManager::OnUploadedPossibleFieldTypes() {
 }
 
 void AutofillManager::OnServerRequestError(
     const std::string& form_signature,
     AutofillDownloadManager::AutofillRequestType request_type,
     int http_error) {
 }
 
 bool AutofillManager::IsAutofillEnabled() const {
-  return const_cast<AutofillManager*>(this)->tab_contents()->profile()->
-      GetPrefs()->GetBoolean(prefs::kAutofillEnabled);
+  Profile* profile = static_cast<Profile*>(
+      const_cast<AutofillManager*>(this)->tab_contents()->browser_context());
+  return profile->GetPrefs()->GetBoolean(prefs::kAutofillEnabled);

[Ilya Sherman, 2011/07/21 22:29:23]

Similar question here: Are all clients of GetPrefs() going to need to perform a
static cast?  If it's always safe, can we hide the cast in a wrapper function,
e.g. a static function GetPrefs(tab_contents()->browser_context())?

 }
 
 void AutofillManager::DeterminePossibleFieldTypesForUpload(
     FormStructure* submitted_form) {
   for (size_t i = 0; i < submitted_form->field_count(); i++) {
     const AutofillField* field = submitted_form->field(i);
     FieldTypeSet field_types;
     personal_data_->GetMatchingTypes(field->value, &field_types);
 
     DCHECK(!field_types.empty());
@@ skipping 414 matching lines @@
 void AutofillManager::UnpackGUIDs(int id,
                                   GUIDPair* cc_guid,
                                   GUIDPair* profile_guid) {
   int cc_id = id >> std::numeric_limits<unsigned short>::digits &
       std::numeric_limits<unsigned short>::max();
   int profile_id = id & std::numeric_limits<unsigned short>::max();
 
   *cc_guid = IDToGUID(cc_id);
   *profile_guid = IDToGUID(profile_id);
 }