Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 7462017: views-desktop: Fix sending mousewheel events to the correct view. (Closed)

Created:
9 years, 4 months ago by sadrul
Modified:
9 years, 4 months ago
Reviewers:
DaveMoore, sky
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

views-desktop: Fix sending mousewheel events to the correct view. Mousewheel events, like keyboard events and unlike other mouseevents, are sent to the focused view from the focus-manager, instead of sending to the view at the location of the LocatedEvent. So This needs to be handled from the dekstop/window-manager to send the events to the focused window. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96271

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M views/desktop/desktop_window_view.cc View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
sadrul
9 years, 4 months ago (2011-08-10 20:31:32 UTC) #1
DaveMoore
lgtm
9 years, 4 months ago (2011-08-10 20:32:55 UTC) #2
sky
9 years, 4 months ago (2011-08-17 15:50:35 UTC) #3
LGTM

http://codereview.chromium.org/7462017/diff/1/views/desktop/desktop_window_vi...
File views/desktop/desktop_window_view.cc (right):

http://codereview.chromium.org/7462017/diff/1/views/desktop/desktop_window_vi...
views/desktop/desktop_window_view.cc:47: virtual bool OnMouseEvent(const
MouseEvent& event) {
OVERRIDE

Powered by Google App Engine
This is Rietveld 408576698