Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Issue 7462016: NaCl: Update revision in DEPS, r6339 -> r6386 (Closed)

Created:
9 years, 4 months ago by Mark Seaborn
Modified:
9 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, bradn, bsy, eaeltsin, jvoung - send to chromium..., khimg, krasin1, Karl, Roland McGrath, Mark Seaborn, pasko-google - do not use, polina, robertm, sehr (please use chromium)
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r6339 -> r6386 This pulls in the following Native Client changes: r6340: (mcgrathr) Remove __pthread_shutdown r6341: (mseaborn) Add test for repeated, sequential pthread_create()+pthread_join() r6342: (mseaborn) Get more information about failures of the multiple-sandboxes test r6343: (jvoung) Warn on unused results when calling nacl thread ctors and check return values where missing. r6344: (krasin) service runtime: remove unused work_queue field from NaClApp. r6345: (sehr) Eliminate browser API agnostic base classed from the plugin. r6346: (mcgrathr) Update glibc revision to facb66a r6347: (polina) PPAPI Proxy: remove calls to remote PPP_Instance::DidDestroy and r6348: (mcgrathr) Build IRT and in-tree tests with private libraries, drop non-IRT support from libnacl r6349: (mcgrathr) Fix leak_test after r6348 r6350: (kschimpf) Compress the prefix/opcode tables, removing approximately 2300 entries. r6351: (kschimpf) Modify the x86-32 validator to generate more detailed messages when not in r6352: (kschimpf) Fix bug in revision 6351. r6353: (mcgrathr) Bump toolchain DEPS to 6349 r6354: (bradnelson) Revert 6353 - Bump toolchain DEPS to 6349 r6355: (khim) Pull 84d7d30. Enable static tests in glibc-tests. r6356: (eaeltsin) Get rid of old tool names completely r6357: (mseaborn) x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S r6358: (khim) Bump DEPS file, enable run_glibc_static_hello_test. r6359: (khim) Fix the bots. r6360: (khim) Fix *-spec bots. r6361: (khim) Fix lucid_64-newlib-x86_64-spec bot. r6362: (jvoung) Run pnacl sandboxed translators with IRT blob loaded (ask sel_universal to). r6363: (ncbray) Refactored NaClAppLoadFile by pulling code out into seperate functions. r6364: (khim) Final (hopefully) fix for *-spec bot. r6365: (mcgrathr) Initialize "second TLS" pointer in thread_create syscall r6366: (jvoung) Scoot pnacl DEPS revision back until the toolchain with the driver r6367: (mseaborn) Revert r6357: "x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S" r6368: (robertm) Added secondary event queue so that we do not overflow r6369: (mcgrathr) Add valgrind trybots to default set r6370: (pasko) Bump REVISIONS for newlib r6371: (mseaborn) atomic_ops_test: Simplify by using joinable threads r6372: (jvoung) Add steps to build pnacl sandboxed toolchain prerequisites if they aren't r6373: (sehr) Remove the now-obsolete nacl_startup function. r6374: (sehr) Revert r6373. r6375: (bsy) enable manifest file access before pepper initialization. r6376: (mcgrathr) Reimplement pthread thread-specific data using __thread r6377: (mcgrathr) Don't build all of libpthread for the IRT r6378: (sehr) Second try to remove obsolete startup function, nacl_startup. This change r6379: (mseaborn) Multiple sandboxes test: Use NaClExit() instead of an implicit exit() r6380: (mcgrathr) Remove irt_elf_utils r6381: (mcgrathr) Remove __nc_adopt_thread r6382: (jvoung) Bump toolchain deps. r6384: (pasko) Toolchain DEPS up(6382). r6385: (pasko) Bump REVISIONS for newlib. r6386: (mseaborn) x86 CPUID check: Fix inline assembly to declare that it clobbers %eax Re-enable NaCl tests on Mac since the Mac Clang build is fixed by r6386. BUG=91371 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96298

Patch Set 1 #

Patch Set 2 : Re-enable on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
9 years, 4 months ago (2011-08-10 20:18:35 UTC) #1
Nick Bray
LGTM
9 years, 4 months ago (2011-08-10 20:27:42 UTC) #2
Nico
rubber-stampy LGTM Maybe add a BUG=91371 line
9 years, 4 months ago (2011-08-10 20:35:26 UTC) #3
bradn
LGTM
9 years, 4 months ago (2011-08-10 21:10:40 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-11 02:02:29 UTC) #5
Change committed as 96298

Powered by Google App Engine
This is Rietveld 408576698