Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 7462009: Enable hybi WebSocket protocol by default. (Closed)

Created:
9 years, 5 months ago by Yuta Kitamura
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Erik does not do reviews, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enable hybi WebSocket protocol by default. This CL enables the new WebSocket protocol by overriding the value of WebCore::Settings::useHixie76WebSocketProtocol() to false. It is known that WebSocket instances initialized in worker context use the old hixie76 protocol even after this change is applied (see https://bugs.webkit.org/show_bug.cgi?id=64852). I'm going to take care of it after this CL is committed. BUG=64470 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/test/data/extensions/api_test/websocket/test.html View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/test/worker_uitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Yuta Kitamura
Hi, could you review this? Please focus on: tony: webpreferences.{h.cc} dimich: Worker test rafaelw: Extensions ...
9 years, 5 months ago (2011-07-20 11:37:07 UTC) #1
tony
webpreferences LGTM
9 years, 5 months ago (2011-07-20 18:02:34 UTC) #2
rafaelw
test change lg
9 years, 5 months ago (2011-07-20 18:08:12 UTC) #3
Yuta Kitamura
Hi Dmitry, could you review worker_uitest.cc as an OWNER? I'd also appreciate your comments for ...
9 years, 5 months ago (2011-07-21 20:47:34 UTC) #4
Dmitry Titov
worker_uitest LGTM
9 years, 5 months ago (2011-07-22 00:29:51 UTC) #5
commit-bot: I haz the power
9 years, 5 months ago (2011-07-22 08:24:48 UTC) #6
Change committed as 93578

Powered by Google App Engine
This is Rietveld 408576698