ntp4 info bubble

chrome/browser/resources/ntp4/new_tab.js

Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 8462398b7ab3594076cc735495dbc919e3dda500..be1fa3e6a075e1309eb97530a2f8db223169bc94 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -110,6 +110,14 @@ cr.define('ntp4', function() {
   var highlightAppId = null;
 
   /**
+   * If non-null, an info bubble for showing messages to the user. It points at
+   * the Most Visited label, and is used to draw more attention to the
+   * navigation dot UI.
+   * @type {!Element|undefined}
+   */
+  var infoBubble;
+
+  /**
    * The time in milliseconds for most transitions.  This should match what's
    * in new_tab.css.  Unfortunately there's no better way to try to time
    * something to occur until after a transition has completed.
@@ -187,6 +195,15 @@ cr.define('ntp4', function() {
     appendTilePage(mostVisitedPage, localStrings.getString('mostvisited'));
     chrome.send('getMostVisited');
 
+    if (localStrings.getString('ntp4_intro_message')) {
+      infoBubble = new cr.ui.Bubble;
+      infoBubble.attach(mostVisitedPage.navigationDot);
+      infoBubble.setText(localStrings.getString('ntp4_intro_message'));

[arv (Not doing code reviews), 2011/08/13 00:44:01]

Why not use a setter?

infoBubble.text = localStrings.getString('ntp4_intro_message');

+      infoBubble.show();
+
+      chrome.send('introMessageSeen');
+    }
+
     bookmarksPage = new ntp4.BookmarksPage();
     appendTilePage(bookmarksPage, localStrings.getString('bookmarksPage'));
     chrome.send('getBookmarks');
@@ -406,6 +423,8 @@ cr.define('ntp4', function() {
 
     dotList.appendChild(newDot);
     page.navigationDot = newDot;
+    if (infoBubble)
+      window.setTimeout(infoBubble.reposition.bind(infoBubble), 0);
 
     eventTracker.add(page, 'pagelayout', onPageLayout);
   }
@@ -594,9 +613,6 @@ cr.define('ntp4', function() {
     } else if (page.classList.contains('bookmarks-page')) {
       shownPage = templateData['bookmarks_page_id'];
       shownPageIndex = 0;
-    } else if (page.classList.contains('bookmarks-page')) {
-      shownPage = templateData['bookmarks_page_id'];
-      shownPageIndex = 0;
     } else {
       console.error('unknown page selected');
     }