Issue 7461154: Support queuing input buffers when OMX's buffer list is exhausted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461154: Support queuing input buffers when OMX's buffer list is exhausted. (Closed)

Created:
9 years, 4 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 4 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), piman, vjain, cfreeman, vhiremath

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support queuing input buffers when OMX's buffer list is exhausted. Previously we'd crash (DCHECK in Debug, SEGV in Release) if the client (plugin) requested more than 10 concurrent Decode()s, because that's how many input buffers the OMX component would have. Now we just queue extra Decode()s and drain them as we get buffers back from the decoder. Added test coverage. BUG=none TEST=ovdatest, gles2 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96615

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -39 lines)			Patch
M	content/common/gpu/media/omx_video_decode_accelerator.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/common/gpu/media/omx_video_decode_accelerator.cc	View	4 chunks	+13 lines, -10 lines	0 comments	Download
M	content/common/gpu/media/omx_video_decode_accelerator_unittest.cc	View	12 chunks	+42 lines, -25 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

vrk: please review piman: FYI since you asked for this.

9 years, 4 months ago (2011-08-10 22:52:45 UTC) #1

vrk (LEFT CHROMIUM)

9 years, 4 months ago (2011-08-12 20:56:59 UTC) #2

LGTM

http://codereview.chromium.org/7461154/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right):

http://codereview.chromium.org/7461154/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:778: // -
Number of concurrent in-flight Decode() calls per decoder.
nit: order of params is wrong (should be 3rd param)

Expand Messages | Collapse Messages