Issue 7461148: ntp4: fix some bugs that appeared when I changed the margin size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461148: ntp4: fix some bugs that appeared when I changed the margin size (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
csilv

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: fix some bugs that appeared when I changed the margin size 1. set a proper minWidth on tileGrid, this is so that if you shrink the browser a lot you can still see the tiles (they don't start disappearing behind a white sheet on the right side) 2. fix coordinate calculation during drag destination calculation (this was already wrong but became more apparently so when I increased the margins). BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96628

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/browser/resources/ntp4/tile_page.js	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages