Issue 7461147: Add the PP_Instance to resource object base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461147: Add the PP_Instance to resource object base. (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Add the PP_Instance to resource object base. This will allow us to get the instance for a resource consistently in the proxy and webkit glue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96473

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test fixed. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
M	ppapi/proxy/plugin_resource.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/resource_object_base.h	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/resource_object_base.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/resource.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/url_request_info_unittest.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

9 years, 4 months ago (2011-08-10 20:17:34 UTC) #2

LGTM with changes.

http://codereview.chromium.org/7461147/diff/1/ppapi/shared_impl/resource_obje...
File ppapi/shared_impl/resource_object_base.h (right):

http://codereview.chromium.org/7461147/diff/1/ppapi/shared_impl/resource_obje...
ppapi/shared_impl/resource_object_base.h:59: ResourceObjectBase(PP_Instance
instance);
explicit

http://codereview.chromium.org/7461147/diff/1/ppapi/shared_impl/resource_obje...
ppapi/shared_impl/resource_object_base.h:79:
DISALLOW_COPY_AND_ASSIGN(ResourceObjectBase);
DISALLOW_IMPLICIT_CONSTRUCTORS to disallow the default ctor?

Expand Messages | Collapse Messages