[Mac] Unspoofable infobars v3.

[Mac] Unspoofable infobars v3.

This brings back the arrow-tip infobar, but it is fixed-with and will not grow
all the way to the omnibox decoration if the bookmark bar is open.

XIB changes:
* Make the animatable view and gradient view 48px tall.
* Move the text view up 1 px.

BUG=76381
TEST=Look at infobars.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95649

[Robert Sesek, 2011-08-04 20:32:22]

Screenshots: http://cl.ly/1K123L1o132I3y033e33 and
http://cl.ly/3k1M0t3r051P2j0d2J1r

[rohitrao (ping after 24h), 2011-08-05 14:24:12]

LGTM

Much simpler when it's fixed height.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (right):

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:184: for
(InfoBarController* controller in infobarControllers_.get())
Add a comment reminding us that NSHeight(eachInfobar) includes the tip, so
that's why we're subtracting it away.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:187: // If
there's any infobars, add a little extra room for the tip of the first
s/there's/there are/

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm (right):

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:16: const CGFloat
kTipWidth = 23;
Might as well put this in a namespace.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:19: -
(NSPoint)pointForTipApex;
Add a comment for this method.  Mention what coordinate system the returned
value is in, not that it isn't obvious.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:126: id controller =
[[self window] windowController];
Can we do this through a delegate interface instead?  If we have to rewrite the
view hierarchy to make fullscreen better, this view may end up in a completely
different window.  I'd like to minimize the number of times we reach up and talk
to the windowcontroller.

Can be in another CL, if you'd like.

[Robert Sesek, 2011-08-05 15:10:40]

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (right):

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:184: for
(InfoBarController* controller in infobarControllers_.get())
On 2011/08/05 14:24:12, rohitrao wrote:
> Add a comment reminding us that NSHeight(eachInfobar) includes the tip, so
> that's why we're subtracting it away.

Done.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:187: // If
there's any infobars, add a little extra room for the tip of the first
On 2011/08/05 14:24:12, rohitrao wrote:
> s/there's/there are/

Done.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm (right):

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:16: const CGFloat
kTipWidth = 23;
On 2011/08/05 14:24:12, rohitrao wrote:
> Might as well put this in a namespace.

Done.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:19: -
(NSPoint)pointForTipApex;
On 2011/08/05 14:24:12, rohitrao wrote:
> Add a comment for this method.  Mention what coordinate system the returned
> value is in, not that it isn't obvious.

Done.

http://codereview.chromium.org/7461134/diff/2002/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm:126: id controller =
[[self window] windowController];
On 2011/08/05 14:24:12, rohitrao wrote:
> Can we do this through a delegate interface instead?  If we have to rewrite
the
> view hierarchy to make fullscreen better, this view may end up in a completely
> different window.  I'd like to minimize the number of times we reach up and
talk
> to the windowcontroller.
> 
> Can be in another CL, if you'd like.

Routed through protocols. Done.

[rohitrao (ping after 24h), 2011-08-05 15:32:32]

LGTM