Issue 7461132: base: Get rid of a deprecated version of file_util::GetFileExtensionFromPath().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461132: base: Get rid of a deprecated version of file_util::GetFileExtensionFromPath(). (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Get rid of a deprecated version of file_util::GetFileExtensionFromPath(). BUG=76112 TEST=None R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95467

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -13 lines)			Patch
	M	base/file_util.cc	View		2 chunks	+4 lines, -12 lines	0 comments	Download
	M	base/file_util_deprecated.h	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/7461132/diff/1/base/file_util_deprecated.h File base/file_util_deprecated.h (right): http://codereview.chromium.org/7461132/diff/1/base/file_util_deprecated.h#newcode35 base/file_util_deprecated.h:35: BASE_API std::wstring GetFileExtensionFromPath(const std::wstring& path); There are more just ...

9 years, 4 months ago (2011-08-04 18:55:07 UTC) #1

LGTM

Expand Messages | Collapse Messages