Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 7461125: No need to have DevToolsManager reference counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager_unittest.cc
diff --git a/content/browser/debugger/devtools_manager_unittest.cc b/content/browser/debugger/devtools_manager_unittest.cc
index fa8027c4f1140d0598b6db96d26248bdc315619f..62accb22ac9182d025a72fd029224519d602f373 100644
--- a/content/browser/debugger/devtools_manager_unittest.cc
+++ b/content/browser/debugger/devtools_manager_unittest.cc
@@ -74,38 +74,38 @@ class DevToolsManagerTest : public RenderViewHostTestHarness {
};
TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
- scoped_refptr<DevToolsManager> manager(new DevToolsManager());
+ DevToolsManager manager;
- DevToolsClientHost* host = manager->GetDevToolsClientHostFor(rvh());
+ DevToolsClientHost* host = manager.GetDevToolsClientHostFor(rvh());
EXPECT_TRUE(NULL == host);
TestDevToolsClientHost client_host;
- manager->RegisterDevToolsClientHostFor(rvh(), &client_host);
+ manager.RegisterDevToolsClientHostFor(rvh(), &client_host);
// Test that just registered devtools host is returned.
- host = manager->GetDevToolsClientHostFor(rvh());
+ host = manager.GetDevToolsClientHostFor(rvh());
EXPECT_TRUE(&client_host == host);
EXPECT_EQ(0, TestDevToolsClientHost::close_counter);
// Test that the same devtools host is returned.
- host = manager->GetDevToolsClientHostFor(rvh());
+ host = manager.GetDevToolsClientHostFor(rvh());
EXPECT_TRUE(&client_host == host);
EXPECT_EQ(0, TestDevToolsClientHost::close_counter);
client_host.Close();
EXPECT_EQ(1, TestDevToolsClientHost::close_counter);
- host = manager->GetDevToolsClientHostFor(rvh());
+ host = manager.GetDevToolsClientHostFor(rvh());
EXPECT_TRUE(NULL == host);
}
TEST_F(DevToolsManagerTest, ForwardMessageToClient) {
- scoped_refptr<DevToolsManager> manager(new DevToolsManager());
+ DevToolsManager manager;
TestDevToolsClientHost client_host;
- manager->RegisterDevToolsClientHostFor(rvh(), &client_host);
+ manager.RegisterDevToolsClientHostFor(rvh(), &client_host);
EXPECT_EQ(0, TestDevToolsClientHost::close_counter);
IPC::Message m;
- manager->ForwardToDevToolsClient(rvh(), m);
+ manager.ForwardToDevToolsClient(rvh(), m);
EXPECT_TRUE(&m == client_host.last_sent_message);
client_host.Close();
« no previous file with comments | « content/browser/debugger/devtools_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698