Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/browser/debugger/devtools_manager.h

Issue 7461125: No need to have DevToolsManager reference counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | content/browser/debugger/devtools_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager.h
diff --git a/content/browser/debugger/devtools_manager.h b/content/browser/debugger/devtools_manager.h
index a7f49826d1acf7ef1d0aeb9df3ec5ea6ea7bd3c7..43349040835e04b47f222f427d50a8930eaa04ba 100644
--- a/content/browser/debugger/devtools_manager.h
+++ b/content/browser/debugger/devtools_manager.h
@@ -9,7 +9,6 @@
#include <map>
#include <string>
-#include "base/memory/ref_counted.h"
#include "content/browser/debugger/devtools_client_host.h"
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
@@ -30,12 +29,12 @@ typedef std::map<std::string, std::string> DevToolsRuntimeProperties;
// This class is a singleton that manages DevToolsClientHost instances and
// routes messages between developer tools clients and agents.
class DevToolsManager : public DevToolsClientHost::CloseListener,
- public NotificationObserver,
- public base::RefCounted<DevToolsManager> {
+ public NotificationObserver {
public:
static DevToolsManager* GetInstance();
DevToolsManager();
+ virtual ~DevToolsManager();
// Returns DevToolsClientHost registered for |inspected_rvh| or NULL if
// there is no alive DevToolsClientHost registered for |inspected_rvh|.
@@ -81,10 +80,6 @@ class DevToolsManager : public DevToolsClientHost::CloseListener,
void CloseAllClientHosts();
private:
- friend class base::RefCounted<DevToolsManager>;
-
- virtual ~DevToolsManager();
-
// DevToolsClientHost::CloseListener override.
// This method will remove all references from the manager to the
// DevToolsClientHost and unregister all listeners related to the
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | content/browser/debugger/devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698