Issue 7461125: No need to have DevToolsManager reference counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461125: No need to have DevToolsManager reference counted (Closed)

Created:
9 years, 4 months ago by yurys

Modified:
9 years, 4 months ago

Reviewers:
caseq, pfeldman

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

No need to have DevToolsManager reference counted Now that ForceReopenWindow method is gone(in r91695), the browser process should own the DevToolsManager. BUG=None TEST=existing DevTools tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95396

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -18 lines)			Patch
M	chrome/browser/browser_process_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/debugger/devtools_manager.h	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	content/browser/debugger/devtools_manager_unittest.cc	View	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages