Issue 7461114: Make hanja key customizable.

Issue 7461114: Make hanja key customizable. (Closed)

Created:
9 years, 5 months ago by Seigo Nonaka

Modified:
9 years, 4 months ago

Reviewers:
Jun Mukai, Yusuke Sato

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Make hanja key customizable. BUG=chromium-os:18127 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95391

Patch Set 2 : Fixed some comment #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
M	chrome/browser/chromeos/language_preferences.h	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/language_preferences.cc	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

lgtm with nits http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/language_preferences.cc File chrome/browser/chromeos/language_preferences.cc (right): http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/language_preferences.cc#newcode29 chrome/browser/chromeos/language_preferences.cc:29: // For Traditional Chinese input method ...

9 years, 5 months ago (2011-07-27 23:58:06 UTC) #2

Seigo Nonaka

http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/language_preferences.cc File chrome/browser/chromeos/language_preferences.cc (right): http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/language_preferences.cc#newcode29 chrome/browser/chromeos/language_preferences.cc:29: // For Traditional Chinese input method (ibus-chewing) On 2011/07/27 ...

9 years, 4 months ago (2011-08-01 05:15:32 UTC) #3

Yusuke Sato

9 years, 4 months ago (2011-08-01 05:56:05 UTC) #4

On 2011/08/01 05:15:32, nona1 wrote:
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> File chrome/browser/chromeos/language_preferences.cc (right):
> 
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> chrome/browser/chromeos/language_preferences.cc:29: // For Traditional Chinese
> input method (ibus-chewing)
> On 2011/07/27 23:58:06, Yusuke Sato wrote:
> > ibus-mozc-chewing
> I confirmed this line is already fixed.
> 
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> chrome/browser/chromeos/language_preferences.cc:142: // For Korean input
method
> (ibus-hangul)
> On 2011/07/27 23:58:06, Yusuke Sato wrote:
> > ibus-mozc-hangul
> 
> Done.
> 
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> File chrome/browser/chromeos/language_preferences.h (right):
> 
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> chrome/browser/chromeos/language_preferences.h:93: // For Korean input method
> (ibus-hangul)
> On 2011/07/27 23:58:06, Yusuke Sato wrote:
> > ibus-mozc-hangul
> 
> Done.
> 
>
http://codereview.chromium.org/7461114/diff/1/chrome/browser/chromeos/languag...
> chrome/browser/chromeos/language_preferences.h:97: extern const char
> kHangulHanjaKeysConfigName[];
> On 2011/07/27 23:58:06, Yusuke Sato wrote:
> > After this CL is submitted, please create another CL to remove the config
> items
> > for ibus-hangul (line 97-98) as well as other '// TODO(nona): remove
> ibus-hangul
> > support' stuff.
> > 
> 
> OK

lgtm

Expand Messages | Collapse Messages