Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/test/live_sync/sync_datatype_helper.cc

Issue 7461109: Allow sync integration tests to operate on multiple datatypes: Typed Urls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback; rebase Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/live_sync/sync_datatype_helper.h ('k') | chrome/test/live_sync/sync_errors_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/sync_datatype_helper.cc
diff --git a/chrome/test/live_sync/sync_datatype_helper.cc b/chrome/test/live_sync/sync_datatype_helper.cc
index 5040295945b489981e1862a691aa30c7257efff6..baa94db0db6242b448ab456d9d15d8e061642c81 100644
--- a/chrome/test/live_sync/sync_datatype_helper.cc
+++ b/chrome/test/live_sync/sync_datatype_helper.cc
@@ -6,22 +6,24 @@
#include "chrome/test/live_sync/live_sync_test.h"
-SyncDatatypeHelper::SyncDatatypeHelper() {}
+namespace {
-SyncDatatypeHelper::~SyncDatatypeHelper() {}
+// The LiveSyncTest instance associated with sync_datatype_helper.
+static LiveSyncTest* test = NULL;
-// static
-void SyncDatatypeHelper::AssociateWithTest(LiveSyncTest* test) {
+} // namespace
+
+namespace sync_datatype_helper {
+
+void AssociateWithTest(LiveSyncTest* test) {
ASSERT_TRUE(test != NULL) << "Cannot associate with null test.";
- ASSERT_TRUE(test_ == NULL) << "Already associated with a test.";
- test_ = test;
+ ASSERT_TRUE(::test == NULL) << "Already associated with a test.";
+ ::test = test;
}
-// static
-LiveSyncTest* SyncDatatypeHelper::test() {
- EXPECT_TRUE(test_ != NULL) << "Must call AssociateWithTest first.";
- return test_;
+LiveSyncTest* test() {
+ EXPECT_TRUE(::test != NULL) << "Must call AssociateWithTest first.";
+ return ::test;
}
-// static
-LiveSyncTest* SyncDatatypeHelper::test_ = NULL;
+} // namespace sync_datatype_helper
« no previous file with comments | « chrome/test/live_sync/sync_datatype_helper.h ('k') | chrome/test/live_sync/sync_errors_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698