Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 7461107: Use type info for the ToBoolean translation in crankshaft. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/code-stubs-ia32.cc
===================================================================
--- src/ia32/code-stubs-ia32.cc (revision 8757)
+++ src/ia32/code-stubs-ia32.cc (working copy)
@@ -258,12 +258,6 @@
// 'null' -> false.
CheckOddball(masm, NULL_TYPE, factory->null_value(), false, &patch);
- bool need_map =
- types_.Contains(SPEC_OBJECT) |
- types_.Contains(STRING) |
- types_.Contains(HEAP_NUMBER) |
- types_.Contains(INTERNAL_OBJECT);
-
if (types_.Contains(SMI)) {
// Smis: 0 -> false, all other -> true
Label not_smi;
@@ -274,12 +268,12 @@
}
__ ret(1 * kPointerSize);
__ bind(&not_smi);
- } else if (need_map) {
+ } else if (types_.NeedsMap()) {
// If we need a map later and have a Smi -> patch.
__ JumpIfSmi(argument, &patch, Label::kNear);
}
- if (need_map) {
+ if (types_.NeedsMap()) {
__ mov(map, FieldOperand(argument, HeapObject::kMapOffset));
// Everything with a map could be undetectable, so check this now.
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698