Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows cast error. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index b6b08ea2cbeb08e40b5e1f663b5defdee4223ecf..b7c15445528a27e4f729432973c87fc3377138ca 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -16,6 +16,11 @@
#include "grit/webkit_strings.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebRect.h"
+// See http://openradar.appspot.com/9896491. This SPI has been tested on 10.5,
+// 10.6, and 10.7. It allows accessibility clients to observe events posted on
+// this object.
+extern "C" void NSAccessibilityUnregisterUniqueIdForUIElement(id element);
+
typedef WebAccessibility::IntAttribute IntAttribute;
typedef WebAccessibility::StringAttribute StringAttribute;
@@ -247,6 +252,7 @@ NSDictionary* attributeToMethodNameMap = nil;
// Deletes our associated BrowserAccessibilityMac.
- (void)dealloc {
if (browserAccessibility_) {
+ NSAccessibilityUnregisterUniqueIdForUIElement(self);
delete browserAccessibility_;
browserAccessibility_ = NULL;
}
@@ -830,5 +836,9 @@ NSDictionary* attributeToMethodNameMap = nil;
return browserAccessibility_->renderer_id();
}
+- (BOOL)accessibilityShouldUseUniqueId {
+ return YES;
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698