chrome/browser/renderer_host/render_widget_host_view_mac.mm - Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 7461104: Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Windows cast error. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/accessibility/browser_accessibility_manager_unittest.cc ('k') | chrome/browser/renderer_host/render_widget_host_view_win.cc » ('j') | content/browser/accessibility/browser_accessibility_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm

index 7b66497cfca1244c757fe55e797fa0080f2222f5..791bac78f8c0e56f4b9fed9275855ff3b5939c28 100644

--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1060,12 +1060,9 @@ void RenderWidgetHostViewMac::SetBackground(const SkBitmap& background) {

void RenderWidgetHostViewMac::OnAccessibilityNotifications(

const std::vector<ViewHostMsg_AccessibilityNotification_Params>& params) {

if (!browser_accessibility_manager_.get()) {

- // Use empty document to process notifications

- webkit_glue::WebAccessibility empty_document;

- empty_document.role = WebAccessibility::ROLE_WEB_AREA;

- empty_document.state = 0;

browser_accessibility_manager_.reset(

- BrowserAccessibilityManager::Create(cocoa_view_, empty_document, NULL));

+ BrowserAccessibilityManager::CreateEmptyDocument(

+ cocoa_view_, static_cast<WebAccessibility::State>(0), NULL));

}

browser_accessibility_manager_->OnAccessibilityNotifications(params);

}