Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

content/browser/accessibility/browser_accessibility_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <execinfo.h>
 
 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
 
 #include <map>
 
@@ skipping 228 matching lines @@
 
 - (id)initWithObject:(BrowserAccessibility*)accessibility
             delegate:(id<BrowserAccessibilityDelegateCocoa>)delegate {
   if ((self = [super init])) {
     browserAccessibility_ = accessibility;
     delegate_ = delegate;
   }
   return self;
 }
 
+extern "C" void NSAccessibilityUnregisterUniqueIdForUIElement(id element);

[dmazzoni, 2011/08/02 06:19:35]

Is this not in any include files?

Does it maybe belong in base/mac/cocoa_protocols or something like that? Maybe
ask Nico or Stuart or one of the other Mac devs. If all else fails, put it at
the top of the file and add a comment explaining why it's forward-declarered -
like if it was only defined in 10.6.

[David Tseng, 2011/08/02 21:30:57]

I couldn't find it in any header files. I'm guessing it's defined in a framework
dylib we link against?  I'll add Nico for comment.
On 2011/08/02 06:19:35, Dominic Mazzoni wrote:

 // Deletes our associated BrowserAccessibilityMac.
 - (void)dealloc {
   if (browserAccessibility_) {
+    NSAccessibilityUnregisterUniqueIdForUIElement(self);
     delete browserAccessibility_;
     browserAccessibility_ = NULL;
   }
 
   [super dealloc];
 }
 
 // Returns an array of BrowserAccessibilityCocoa objects, representing the
 // accessibility children of this object.
 - (NSArray*)children {
@@ skipping 563 matching lines @@
   return ([self hash] == [object hash]);
 }
 
 - (NSUInteger)hash {
   // Potentially called during dealloc.
   if (!browserAccessibility_)
     return [super hash];
   return browserAccessibility_->renderer_id();
 }
 
+- (BOOL)accessibilityShouldUseUniqueId {
+  return YES;
+}
+
 @end