Web Intents: Preparatory work.

chrome/browser/intents/register_intent_handler_infobar_delegate.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/intents/register_intent_handler_infobar_delegate.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/common/url_constants.h"
+#include "content/browser/tab_contents/tab_contents.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+RegisterIntentHandlerInfoBarDelegate::RegisterIntentHandlerInfoBarDelegate(
+    TabContents* tab_contents)
+    : ConfirmInfoBarDelegate(tab_contents),
+      tab_contents_(tab_contents) {
+}
+
+InfoBarDelegate::Type
+    RegisterIntentHandlerInfoBarDelegate::GetInfoBarType() const {
+  return PAGE_ACTION_TYPE;
+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetMessageText() const {
+  return l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,
+                                    string16(), string16());
+}
+
+int RegisterIntentHandlerInfoBarDelegate::GetButtons() const {
+  return BUTTON_OK | BUTTON_CANCEL;

[Peter Kasting, 2011/07/26 22:52:12]

Nit: You can eliminate this function entirely -- it duplicates the default
ConfirmInfoBarDelegate behavior.

[James Hawkins, 2011/07/26 23:04:56]

Done.

+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetButtonLabel(
+    InfoBarButton button) const {
+  switch (button) {
+    case BUTTON_OK:
+      return l10n_util::GetStringUTF16(IDS_REGISTER_INTENT_HANDLER_ACCEPT);
+    case BUTTON_CANCEL:
+      return l10n_util::GetStringFUTF16(IDS_REGISTER_INTENT_HANDLER_DENY,
+                                        string16());

[Peter Kasting, 2011/07/26 22:52:12]

This extra arg shouldn't be here.

[James Hawkins, 2011/07/26 23:04:56]

Done.

+    case BUTTON_NONE:

[Peter Kasting, 2011/07/26 22:52:12]

Getting BUTTON_NONE here is actually illegal.

Nit: I suggest structuring this like most other delegates do, for simplicity and
consistency:

  return l10n_util::GetStringUTF16((button == BUTTON_OK) ?
      IDS_REGISTER_INTENT_HANDLER_ACCEPT : IDS_REGISTER_INTENT_HANDLER_DENY);

I realize this assumes only two button enum values, but we make that assumption
in such a large number of places and it's unlikely enough to change that I'm OK
with that.

[James Hawkins, 2011/07/26 23:04:56]

Removed NONE handling by switching to an if/else. The ACCEPT string takes to
string16() params, so I haven't pulled it as tightly together as you're
suggesting.  I could do something like:

return (button == BUTTON_OK) ? GetStringFUTF16(ACCEPT, ...) :
GetStringUTF16(DENY);

but I feel this is more readable.

+      break;
+  }
+
+  NOTREACHED();
+  return string16();
+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetLinkText() const {
+  return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
+}
+
+bool RegisterIntentHandlerInfoBarDelegate::LinkClicked(
+    WindowOpenDisposition disposition) {
+  // TODO(jhawkins): Open the Web Intents Help Center article once it is
+  // written.
+  // TODO(jhawkins): Add associated bug for the article here.

[Peter Kasting, 2011/07/26 22:52:12]

Nit: What's this mean?

[James Hawkins, 2011/07/26 23:04:56]

I need to file a bug to get the help center article written, then add that bug
to the TODO above this one.

+  return false;
+}