Issue 7461080: [Mac] Respect natural/inverted scroll direction on Lion when gesturing.

Issue 7461080: [Mac] Respect natural/inverted scroll direction on Lion when gesturing. (Closed)

Created:
9 years, 5 months ago by Robert Sesek

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Respect natural/inverted scroll direction on Lion when gesturing. BUG=90342 TEST=With inverted scrolling, swiping left goes forward and swiping right goes backwards. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94122

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add gesture_utils #

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -35 lines)			Patch
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 2	4 chunks	+21 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1	2 chunks	+0 lines, -25 lines	0 comments	Download
A	chrome/browser/ui/cocoa/gesture_utils.h	View	1 2	1 chunk	+22 lines, -0 lines	1 comment	Download
A	chrome/browser/ui/cocoa/gesture_utils.mm	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/7461080/diff/1/chrome/browser/ui/cocoa/browser_window_controller_private.mm File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): http://codereview.chromium.org/7461080/diff/1/chrome/browser/ui/cocoa/browser_window_controller_private.mm#newcode571 chrome/browser/ui/cocoa/browser_window_controller_private.mm:571: - (BOOL)isScrollDirectionInverted { Can you move this and the ...

9 years, 5 months ago (2011-07-26 15:00:18 UTC) #2

Robert Sesek

9 years, 5 months ago (2011-07-26 15:56:02 UTC) #3

Mark Mentovai

9 years, 5 months ago (2011-07-26 18:26:26 UTC) #5

Drive-by stupidity.

http://codereview.chromium.org/7461080/diff/5007/chrome/browser/ui/cocoa/gest...
File chrome/browser/ui/cocoa/gesture_utils.h (right):

http://codereview.chromium.org/7461080/diff/5007/chrome/browser/ui/cocoa/gest...
chrome/browser/ui/cocoa/gesture_utils.h:8: #include <Foundation/Foundation.h>
Don’t need this if you use bool below. Then this file is accessible from C++.

Expand Messages | Collapse Messages