Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 7461075: Revert 94073 (broke a ton of tests) - Introduce a field trial for Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 const OptionsPage = options.OptionsPage; 6 const OptionsPage = options.OptionsPage;
7 const ArrayDataModel = cr.ui.ArrayDataModel; 7 const ArrayDataModel = cr.ui.ArrayDataModel;
8 8
9 // 9 //
10 // BrowserOptions class 10 // BrowserOptions class
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 if (self.instantConfirmDialogShown_) 76 if (self.instantConfirmDialogShown_)
77 chrome.send('enableInstant'); 77 chrome.send('enableInstant');
78 else 78 else
79 OptionsPage.navigateToPage('instantConfirm'); 79 OptionsPage.navigateToPage('instantConfirm');
80 } else { 80 } else {
81 chrome.send('disableInstant'); 81 chrome.send('disableInstant');
82 } 82 }
83 return true; 83 return true;
84 }; 84 };
85 85
86 $('instantFieldTrialCheckbox').addEventListener('change',
87 function(event) {
88 this.checked = true;
89 chrome.send('disableInstant');
90 });
91
92 Preferences.getInstance().addEventListener('instant.confirm_dialog_shown', 86 Preferences.getInstance().addEventListener('instant.confirm_dialog_shown',
93 this.onInstantConfirmDialogShownChanged_.bind(this)); 87 this.onInstantConfirmDialogShownChanged_.bind(this));
94 88
95 Preferences.getInstance().addEventListener('instant.enabled',
96 this.onInstantEnabledChanged_.bind(this));
97
98 var homepageField = $('homepageURL'); 89 var homepageField = $('homepageURL');
99 $('homepageUseNTPButton').onchange = 90 $('homepageUseNTPButton').onchange =
100 this.handleHomepageUseNTPButtonChange_.bind(this); 91 this.handleHomepageUseNTPButtonChange_.bind(this);
101 $('homepageUseURLButton').onchange = 92 $('homepageUseURLButton').onchange =
102 this.handleHomepageUseURLButtonChange_.bind(this); 93 this.handleHomepageUseURLButtonChange_.bind(this);
103 var homepageChangeHandler = this.handleHomepageURLChange_.bind(this); 94 var homepageChangeHandler = this.handleHomepageURLChange_.bind(this);
104 homepageField.addEventListener('change', homepageChangeHandler); 95 homepageField.addEventListener('change', homepageChangeHandler);
105 homepageField.addEventListener('input', homepageChangeHandler); 96 homepageField.addEventListener('input', homepageChangeHandler);
106 homepageField.addEventListener('focus', function(event) { 97 homepageField.addEventListener('focus', function(event) {
107 self.autocompleteList_.attachToInput(homepageField); 98 self.autocompleteList_.attachToInput(homepageField);
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 * Called when the value of the instant.confirm_dialog_shown preference 162 * Called when the value of the instant.confirm_dialog_shown preference
172 * changes. Cache this value. 163 * changes. Cache this value.
173 * @param {Event} event Change event. 164 * @param {Event} event Change event.
174 * @private 165 * @private
175 */ 166 */
176 onInstantConfirmDialogShownChanged_: function(event) { 167 onInstantConfirmDialogShownChanged_: function(event) {
177 this.instantConfirmDialogShown_ = event.value['value']; 168 this.instantConfirmDialogShown_ = event.value['value'];
178 }, 169 },
179 170
180 /** 171 /**
181 * Called when the value of the instant.enabled preference changes. Request
182 * the state of the Instant field trial experiment.
183 * @param {Event} event Change event.
184 * @private
185 */
186 onInstantEnabledChanged_: function(event) {
187 chrome.send('getInstantFieldTrialStatus');
188 },
189
190 /**
191 * Called to set the Instant field trial status.
192 * @param {boolean} enabled If true, the experiment is enabled.
193 * @private
194 */
195 setInstantFieldTrialStatus_: function(enabled) {
196 $('instantEnabledCheckbox').hidden = enabled;
197 $('instantFieldTrialCheckbox').hidden = !enabled;
198 },
199
200 /**
201 * Update the Default Browsers section based on the current state. 172 * Update the Default Browsers section based on the current state.
202 * @param {string} statusString Description of the current default state. 173 * @param {string} statusString Description of the current default state.
203 * @param {boolean} isDefault Whether or not the browser is currently 174 * @param {boolean} isDefault Whether or not the browser is currently
204 * default. 175 * default.
205 * @param {boolean} canBeDefault Whether or not the browser can be default. 176 * @param {boolean} canBeDefault Whether or not the browser can be default.
206 * @private 177 * @private
207 */ 178 */
208 updateDefaultBrowserState_: function(statusString, isDefault, 179 updateDefaultBrowserState_: function(statusString, isDefault,
209 canBeDefault) { 180 canBeDefault) {
210 var label = $('defaultBrowserState'); 181 var label = $('defaultBrowserState');
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 }; 482 };
512 483
513 BrowserOptions.updateStartupPages = function(pages) { 484 BrowserOptions.updateStartupPages = function(pages) {
514 BrowserOptions.getInstance().updateStartupPages_(pages); 485 BrowserOptions.getInstance().updateStartupPages_(pages);
515 }; 486 };
516 487
517 BrowserOptions.updateAutocompleteSuggestions = function(suggestions) { 488 BrowserOptions.updateAutocompleteSuggestions = function(suggestions) {
518 BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions); 489 BrowserOptions.getInstance().updateAutocompleteSuggestions_(suggestions);
519 }; 490 };
520 491
521 BrowserOptions.setInstantFieldTrialStatus = function(enabled) {
522 BrowserOptions.getInstance().setInstantFieldTrialStatus_(enabled);
523 };
524
525 // Export 492 // Export
526 return { 493 return {
527 BrowserOptions: BrowserOptions 494 BrowserOptions: BrowserOptions
528 }; 495 };
529 496
530 }); 497 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/ui/webui/options/browser_options_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698