Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 7461075: Revert 94073 (broke a ton of tests) - Introduce a field trial for Instant. (Closed)

Created:
9 years, 5 months ago by willchan no longer on Chromium
Modified:
9 years, 5 months ago
Reviewers:
sreeram
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Revert 94073 (broke a ton of tests) - Introduce a field trial for Instant. Add a field trial for Instant, opting in 10% of undecided users into the experiment. "Undecided" means that users who have played with the Instant checkbox (in Preferences -> Basics) will be excluded from the field trial. When Instant is turned on in this manner, it's restricted to search (i.e., other non-search URLs are not previewed). If the user is selected into the experiment, the checkbox state in preferences will accurately reflect that Instant is on, even if the user didn't enable it explicitly. Although the experiment enables the "Restrict Instant to Search" functionality, it's not reflected in about:flags. I consider this deficiency to be minor, since (i) most users won't check about:flags anyway, and (ii) about:flags is already inconsistent in other ways (for example, it also doesn't show if you added --restrict-instant-to-search manually). Similarly for --preload-instant-search, which preloads the default search engine's homepage when the omnibox gets keyboard focus. We respect group policy. If prefs::kInstantEnabled is a managed pref, the field trial will not affect the user. We store the actual random number generated for the user in a pref so that the same user gets the same experience across browser restarts (i.e., one-time randomization). This also allows us to change (through a Chrome update) the percentages allocated to different groups and thus allocate users to groups differently. If we only stored the final determination of the user's group in the pref, changing the group percentages would have no effect. The code doesn't use base::FieldTrial, because this experiment needs one-time randomization, and base::FieldTrial only supports it if the user has opted-in to UMA (see http://codereview.chromium.org/7360001/ for some context). There is no explicit expiry date for this experiment. The experiment can be disabled by updating the field trial percentages in instant_field_trial.cc and shipping an update to Chrome (not much different from how base::FieldTrial also requires new builds to expire experiments). BUG=none TEST=Delete profile and restart Chrome enough times to see that Instant is ON by default about 10% of the time; fiddling with the preferences checkbox gives expected results. Review URL: http://codereview.chromium.org/7337007 TBR=sreeram@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -199 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 8 chunks +7 lines, -23 lines 0 comments Download
D chrome/browser/instant/instant_field_trial.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/instant/instant_field_trial.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 3 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/webui/options.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/instant.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
9 years, 5 months ago (2011-07-26 11:09:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698